Re: [XEN PATCH v7 47/51] build: Rework "clean" to clean from the root dir

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Thu, Oct 14, 2021 at 11:44:00AM +0200, Jan Beulich wrote:
> On 24.08.2021 12:50, Anthony PERARD wrote:
> > This will allow "clean" to work from an out-of-tree build when
> > it will be available.
> > 
> > Some of the file been removed in current "clean" target aren't added
> > to $(clean-files) because they are already listed in $(extra-) or
> > $(extra-y).
> > 
> > Also clean files in "arch/x86/boot" from that directory by allowing
> > "clean" to descend into the subdir by adding "boot" into $(subdir-).
> 
> "descend into" (also used in a respective comment) looks contrary to
> doing everything from the root now, at least to me.

That's the language that Kbuild uses. While it is true that we don't
change directory, we still do the build of one directory at a time, and
the build system as its own understanding of what the current directory
is, even if it is different from $(CURDIR).

> > --- a/xen/scripts/Kbuild.include
> > +++ b/xen/scripts/Kbuild.include
> > @@ -98,7 +98,7 @@ build := -f $(srctree)/Rules.mk obj
> >  # Shorthand for $(MAKE) clean
> >  # Usage:
> >  # $(MAKE) $(clean) dir
> > -clean := -f $(abs_srctree)/scripts/Makefile.clean clean -C
> > +clean := -f $(srctree)/scripts/Makefile.clean obj
> 
> Doesn't the comment want changing as well?

Indeed,

Thanks,

-- 
Anthony PERARD