[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [XEN PATCH v7 26/51] build: build everything from the root dir, use obj=$subdir
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
- Date: Thu, 14 Oct 2021 14:33:54 +0100
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none
- Cc: Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "Ian Jackson" <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, "Ross Lagerwall" <ross.lagerwall@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Thu, 14 Oct 2021 13:34:36 +0000
- Ironport-data: A9a23:76SV/60IdpsO9Te7j/bD5e13kn2cJEfYwER7XKvMYLTBsI5bp2QFy 2EeXj+Ca//fM2r0LYtyPdiyoR4C6JGHndVmTAFopC1hF35El5HIVI+TRqvS04J+DSFhoGZPt Zh2hgzodZhsJpPkS5PE3oHJ9RGQ74nRLlbHILOCan0ZqTNMEn970Es7wrJh2+aEvPDia++zk YKqyyHgEAfNNw5cagr4PIra9XuDFNyr0N8plgRWicJj5TcypFFMZH4rHomjLmOQf2VhNrXSq 9Avbl2O1jixEx8FUrtJm1tgG6EAaua60QOm0hK6V0U+6/TrS+NbPqsTbZIhhUlrZzqhs+hey 4Rs75OKQiwwYILhx80NYiV8HHQrVUFG0OevzXmXtMWSywvNcmf2wuUoB0YzVWEa0r8pWycUr 6VecW1TKEDY7w616OvTpu1Ej8I/LM7tLcUHt2tp1z3xBvc6W5HTBa7N4Le02R9t25oURKuPO KL1bxJuSCrJWDd9IW4xUqISpdWxgl3HcwRh/Qf9Sa0fvDGIkV0ZPKLWGNnSfMaDSYNKn0Kbj mXc9m/9D1cRM9n34TGC9HSrhOPGgyLgcI0XHby8sPVthTW7z2gSEwEfVEH9r+OwjEW/QPpAJ 0dS8S0rxYAi+UruQtTjUhmQpH+fogVaS9dWC/c96gyG1uzT+QnxLmQcVTtAdNwOvdc7XyA3z USOm871BDtpq/ueTnf13ruboT69IyE9MX4JZShCSxAMpdbkvukbsBXLSdpyFb+vuff8Ezrw3 jOioTA3gvMYistj/6Sk/3jXjjS0vJ/LQwUpoALNUQqN5ARzbp+ofIys5F3S695PKY+YSh+Ku 31ss8qU4f0KDJqNvDeQW+hLF7asj96aNBXMjFgpGIMunxy24GKqd41U5DB4JW9qP9wCdDuvZ 1Xc0StT+ZtSMX2CfaJxJYWrBKwXIbPITIq/EKqON5wXP8Y3JFTvEDxSiVC481jCkxkNy64FM ryCL+mBUl8KOJhDw2/jLwsC6oMDyic7zGLVYJn0yRW7zLaTDEKopac53EimNb9hsvvVyOnB2 5MGbZHSkkQAOAHrSnCPqdZ7ELwcEZQs6XkaQeRsfemfPhEuJmglD/LAqV/KU904x/oL/gskE 3fUZ6O59LYdrSGYQelpQio6AF8KYXqZhSlmVcDLFQz5s0XPma71sM8im2IfJNHLDtBLw/9uV OUicM6dGPlJQTmv021DNsWk8dQ8K0X121rm08+ZjN4XJMMIq+vhoI6MQ+cS3HNWUnrfWTUW8 tVMKT83sbJcHl8/Xa46mdqkzk+rvGh1pQ6BdxCgHzWnQ221qNICA3Wo1pcfephQQT2elmry/ 1vHWn8w+LiSy7LZBfGU3MhoWa/ySLAgdqebdkGGhYuL2d7ypTH6mtUaDrbWLVgwlgrcoc2fW Amc9NmkWNVvobqAm9YU/29Dwf1s6t3xiaVdywg4TnzHY07yUuFrI2Wc3NkJvapIn+cLtQyzU 0OJ299bJbTWZ5+1TA9PfFIoPraZyPUZujjO9vBpck/00zB6oeicWkJIMhjS1CEEdOlpMJkoy PsKsdIN71DtkQIjN9uL13gG92mFInEafb8gs5UWXN3ihgYxkwkQap3AEC7mppqIbowUYEUtJ zaVgovEhqhdmRWeIyZiSyCV0LME15oUuR1MwFsTHHizm4LI1q0twRlc0TUrVQAJnB9J5P1+Z zpwPEpvKKTQozox3JpfX3qhEh1qDQGC/hCj0EMAkWDUQhX6VmHJK2Fha++B8FpArjBZdzlfu rqZ1HzkQXDhe8Sohnk+XktsqvrCS91t91KdxJD7TprdR5RqMyD4hqKOZHYTr0q1CMw8s0TLu O128bsicqb8LyMR//U2BoTyOW78k/xYyLiumc1cwZ4=
- Ironport-hdrordr: A9a23:DvHEtK0eeTwa/KvjGOTRdQqjBL4kLtp133Aq2lEZdPUCSL39qy ncppUmPH7P5wr5N0tNpTntAsO9qDbnhP1ICOoqVotKPjOHhILAFugL0WKh+UyDJ8SUzJ856U 4PScVD4JSbNzZHsfo=
- Ironport-sdr: DjcxAUayJnJEou+aQN4yeHHnz01yliQ1tilWzEqc9HxnJKquo+6Q0rMqWqdIuM4VMQ28lZwEQE yY7OCNYXL8F0JPP9ig+eL3PjyDxDcual8Pe+Rj8cteR80BWAX5y+7CMJm1GP+Ye+I97KxD18y5 4Zh7efSn7N41nJ8A1yjSZCcLW5i2l0+6a+F95v2Ywqk4bBwBRrmY1UtH6j2qzAEMuRWlm9HdbM dQwl/vgY0pygf7V0nZEduBJE4W3rc2y1+Gr3S8i+ivzbiIVmu8wQESbl8aUiLV53E9V2Q08pBp 70jJpEAGMs5amiZ8fxV66Vd7
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Wed, Oct 13, 2021 at 03:24:31PM +0100, Anthony PERARD wrote:
> On Mon, Oct 11, 2021 at 04:02:22PM +0200, Jan Beulich wrote:
> > On 24.08.2021 12:50, Anthony PERARD wrote:
> > > ifeq ($(CONFIG_ENFORCE_UNIQUE_SYMBOLS),y)
> > > cmd_cc_o_c = $(CC) $(c_flags) -c $< -o $(dot-target).tmp -MQ $@
> > > ifeq ($(CONFIG_CC_IS_CLANG),y)
> > > - cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $<=$(SRCPATH)/$<
> > > $(dot-target).tmp $@
> > > + cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$<
> > > $(dot-target).tmp $@
> >
> > Are you sure about the $< => $(<F) transformation here? Previoiusly it
> > was present only ...
>
> I have to check again. Maybe $< didn't work and it's more obvious with
> this patch. Or maybe that depends on the version of clang.
With clang 12, the original line doesn't work for the few objects that
are built from "subdir/source.c". I guess it is just by luck that they
aren't any duplicated symbols.
> > > else
> > > - cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym
> > > $(<F)=$(SRCPATH)/$< $(dot-target).tmp $@
> > > + cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$<
> > > $(dot-target).tmp $@
> >
> > ... here.
--
Anthony PERARD
|
