[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [XEN PATCH v7 26/51] build: build everything from the root dir, use obj=$subdir

  • To: Anthony PERARD <anthony.perard@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 14 Oct 2021 15:54:48 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Au4/intUNt1F1RcZPZkdcG/pzO04E91WYBj/x6LLBs4=; b=YWUUlp9NlABgAa2IY6lbcS82MXGHg3sbewSpuj+77Lq2TSxoQD+6gC/1J+q8CO8Y2imuaLeEpOl27QwEDhD+5eczk8AMMiKS7ekUl+K6W3t3af6nDTCqtUI/vgq26zmf0ZvGhTsltyNBk5DpxUGEFqqYr+y/gsMF+Cx2F6WdVsk7gigt0y5FffTBsMPTqZ4nJPhiB8ixyIzSNnj628MgjNU686oaApluCm1eepLt9L1tDx/+ODLdZvtM0/bWzNe0A5mkIZmapiUZVt4ZutTpJLcx/wHus84//DlEPgQzGf97Pde6ZyneXDV7WGJuAkdxobYbzIU6Ef19eUNk3fSLDQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mxZeJbcxnjugx7NpTTTxo/6ytnpR4b8MjmkTtlKEOB2wgZAYVoskYdWi4zcbm8ZuMD4XSghPH12IWo+/1sc5lyoJ61jWiIITRNjQxwdRmdTU5PDaN2NCd/lifWotXDsR2ZFmCoNuPLkPx0EPLiYVuXSS3XFeOkMJpxw0qhTfHJUdz2zTMIoxkHPUEUaJw5QIZiyeTUyrAxFMFPUjEBEbUlOwTWzZH760qMTEau7Qxg/SQ5V3d4uQ2rkjOJOj5k+qLEPh9CYemZ9zZnsQxvZD/xM9BIiYyV1NkQP5uwEMtJhp6wVtili3HQ4e+UyW+xYUeLZcZ4DhCxYEqU9JqCCmqg==
  • Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
  • Cc: Bob Eshleman <bobbyeshleman@xxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Julien Grall <julien@xxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Alistair Francis <alistair.francis@xxxxxxx>, Connor Davis <connojdavis@xxxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>, Ross Lagerwall <ross.lagerwall@xxxxxxxxxx>, Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>, "Daniel P. Smith" <dpsmith@xxxxxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
  • Delivery-date: Thu, 14 Oct 2021 13:54:58 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.10.2021 15:33, Anthony PERARD wrote:
> On Wed, Oct 13, 2021 at 03:24:31PM +0100, Anthony PERARD wrote:
>> On Mon, Oct 11, 2021 at 04:02:22PM +0200, Jan Beulich wrote:
>>> On 24.08.2021 12:50, Anthony PERARD wrote:
>>>>      cmd_cc_o_c = $(CC) $(c_flags) -c $< -o $(dot-target).tmp -MQ $@
>>>>      ifeq ($(CONFIG_CC_IS_CLANG),y)
>>>> -        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $<=$(SRCPATH)/$< 
>>>> $(dot-target).tmp $@
>>>> +        cmd_objcopy_fix_sym = $(OBJCOPY) --redefine-sym $(<F)=$< 
>>>> $(dot-target).tmp $@
>>> Are you sure about the $< => $(<F) transformation here? Previoiusly it
>>> was present only ...
>> I have to check again. Maybe $< didn't work and it's more obvious with
>> this patch. Or maybe that depends on the version of clang.
> With clang 12, the original line doesn't work for the few objects that
> are built from "subdir/source.c". I guess it is just by luck that they
> aren't any duplicated symbols.

Well, I recall that there was different behavior and hence different
treatment was needed. If that's no longer the case with your changes,
then that's certainly fine, but will want explaining in the description.




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.