[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/2] x86/shadow: adjust some shadow_set_l<N>e() callers


  • To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • Date: Fri, 15 Oct 2021 10:19:59 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8k7tCjyo4Qq2kUKLUP653B/CUYHYrYdovKTWpM/QmDs=; b=HV58XUNzjhK4jXbOCNRb8QVoiKRUe9rOlGOvcueHcja7/nLmCjcXxbbP778fYhhai0BIEdEXrz1pHrieGWin37L74Jb269eEhRoMyS8NPpdvXkXBfPIcLmPHSN0Ok+oQez1NHQge4FNvRl2GICYz1edQp48Nzt8OoNw8aF9M1lx1zOxgks2TvX1fwvXSnSrJ87besunOD+o9PEk6vkqN8cV4u9X5cBoNqRdTyNXkR+rEt64xQUHrczKNcGsPYJrNnYP2H6K0rkrpUsEPMoG+e/Is4kXsiWiotmAFqw0k3bR9yRILmFxnBDVuWJnFTiuiFg9BvgJziQr8rFWw0DhbLw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Gvz0FIWT/lFTGxTba6VCGihe4py1vt9KlFRSE7nibuUtY4qNFkVwOKhF+okAevjTVk1XImFxzXqn9bNV50eATiQBWXBIN+sf1NeZJK1d0P7mLXkxL9p0aFJdYr3UXsEL3B9be+NzDWqeQ2FlQBIIiVFI2EiXR9PEPv+EOFaN/FzeBO3u903D5wbyUfjabjblrgfO2uIRM7PtYK+V3EunlKO3lSTSLAeaXspjf4Ce1jI1e6vk7XuYPxa8H6JbCTCDr0H2TSdPY6h3p//bLbtTlLh/hTmdQ7U0oOW+sRpdB8eJzgXW/Io37xdNP3BQjkT0bDUlbvmrRjFG9H9PYzfeNQ==
  • Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Tim Deegan <tim@xxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>
  • Delivery-date: Fri, 15 Oct 2021 09:20:20 +0000
  • Ironport-data: A9a23:DT6TDKIn4yW6xL2RFE+RJJIlxSXFcZb7ZxGr2PjKsXjdYENShDZWz DZMWG6HOvzZZGOjedt0OYrk9h9TuZXXzoVgQQplqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo6xrZg6mJVqYPR7z2l6 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB22goxL9 dJupaaIWDsiFYnJoLQxUUBxRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr LpBdW5LPkvra+GemdpXTsFFgMg5IdatF4QYonx6lhnSDOo8QICFSKLPjTNd9Gpv350eRKqAD yYfQSZlQDHYQQRvBnsoF60slcaFvEjuVDIN/Tp5ooJoujOOnWSdyoPFINfTP9CHW8hRtkKZv X7duXT0BAkAM96SwibD9Wij7sfNly7mXIMZFJWj6+VnxlaUwwQ7FBwTfUu2p7++kEHWc81bA 1wZ/Gwpt6dayaCwZoCjBVvi+ifC50NCHYoLewEn1O2T4pXJvzykAUsUdAZQVNcNkMoOFRAoj 3bcyrsFGgdTmLGSTHuc8JKdojWzJTUZIAc+WMMUcecWy4K8+N9r33ojWv4mSfTv1oSkRlkc1 hjT9HBm74j/m/LnwElSEbrvuDmruoTSBjA84gHaTwpJBSsoOdb7OeREBbXdhMuszbp1rHHd4 xDoeODEtYji6K1hcgTWHY3h+5nztp643MX02wIHInXY323FF4SfVY5R+ipiA0xiL9wJfzTkC GeK51gNvsQJZybzPfUpC25UNyjM5fO9fTgCfquMBuein7ArLFPXlM2QTR/4M5/RfLgEzvhkZ MbznTeEBncGE6V3pAdatM9GuYLHMhsWnDuJLbiilkzP+ePHOBa9FOdUWHPTP7tRxP7V/23oH yN3apLiJ+N3C7alPEE6MOc7cDg3EJTMLcuo9pINL7Xdf1MO9aNII6a5/I7NsrdNxsx9vuzJ4 mu8Sglfzl/+jmfAMgKEdjZob7aHYHq1hS9T0fUEMQn61n49T5yo6atDJZI7caN+rL5ozOJuT ulDcMKFW6wdRjPC8jUbTJ/8sI09K0j72VPQZ3KoMGolYpptZw3V4du4LAHhwzYDU3isvswkr rz+ig6CGcgfRx5vBdr9Ye60yw/jpmAUne9/BhOaItRadEj23pJtLij90q0+L80WcE2RzTqGz QeGRxwfoLCV8YMy9dDIg4GCrpuoTLQiThYLQTGD4O/vZyfA/2elzYtRa8qyfGjQBDHu5aGvR eRJ1PWgYvcJq0lH7thnGLFxwKNgu9a2/+1Gzh5pFWngZkiwDu8yOWGP2MRCu/EfxrJdvgfqC EuD9sMDZOeMMcLhVlUQOBAkfqKI0vRNwmve6vE8IUPb4i5r/eXYDRUObkfU0CENfqFoNI4Fw Ps6vJ9E4gOyvRMmL9Kag30G7G+LNHEBD/0qu5xy7FUHUeb3JoWuuaDhNxI=
  • Ironport-hdrordr: A9a23:A48PqKpzzIkh6RlIctiK0KoaV5ulL9V00zEX/kB9WHVpm5Oj+P xGzc526farslsssREb+OxpOMG7MBfhHO1OkPYs1NCZLXXbUQqTXfxfBO7ZrQEIdBeOjtK1uZ 0QFZSWTeeAd2SS7vyKkDVQcexQueVvmZrA7Yy1rwYPPHJXguNbnmBE426gYzxLrWJ9dPgE/f Snl696TnabCA8qhpPRPAh6YwGPnayFqHqgCiR2cCIP2U2rt3eF+bT6Gx+X0lM3VC5O+64r9S zgnxbi7quunvmnwluEvlWjrqh+qZ/E8J9uFcaMgs8aJnHFjRupXp1oX/mnsCouqO+ixV42mJ 3nogsmPe5093TNF1vF7yfF6k3F6nID+nXiwViXjT/KptH4fiszD457iYdQYnLimgAdleA59J gO83OStpJRAx+Ftj/6/cL0WxZjkVfxiWY+kMYI5kYvE7c2Wft0l8gy7UlVGJAPEGbR84Y8Ct RjC8na+bJ/bU6aVXbEpWNiqebcHUjbJi32BnTqh/bllAS/xBtCvg0lLY0k7zc9HasGOtx5D7 +uCNUwqFlMJvVmJp6VSt1xGfdepwT2MGTx2VmpUCHa/Zc8SjrwQq7MkccIDd6RCeg1JbsJ6d n8uQBjxCIPk3yHM7zG4HQMyGGXfFmA
  • Ironport-sdr: XQuiyKc6J94Zx/VxcgzlIyC50Xi4lTUznjPo3Qp1q/KcZXO30R6r1qx7b6lvc9lYsFVsvKLAVd y4DAFS+Baz+lX6d12DtVireQQaSGYbNSwQhigtiygh2HajZeG8zfEoVpAlLIlEKaUb2QNmCWT/ LHoJ5Ft6rVi9EMhWBVID5zsU0Zs23Ym7yZI4DcTckHBmTsMrDq7Qlg+AN9MNQiDB/L3AGCaMN1 RlJWph945m45YuNgI2kr9QwOL3oTU82ihqhw94OHBFZ3UCgPTl7q8QFDvE92xtAE8y0TIrKuRF zhEaandxlnSSRUFLo83WS9F3
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13/10/2021 16:37, Jan Beulich wrote:
> Coverity dislikes sh_page_fault() storing the return value into a local
> variable but then never using the value (and oddly enough spots this in
> the 2- and 3-level cases, but not in the 4-level one). Instead of adding
> yet another cast to void as replacement, take the opportunity and drop a
> bunch of such casts at the same time - not using function return values
> is a common thing to do. (It of course is an independent question
> whether ignoring errors like this is a good idea.)
>
> Coverity-ID: 1492856
> Coverity-ID: 1492858
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.