[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM
- To: Stefano Stabellini <sstabellini@xxxxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Fri, 15 Oct 2021 15:21:53 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BkrKpOlu2K+v/47oj3jFI8xlPKPStmSbUstRAuprWc0=; b=HQzSgE1deITsTg3zlhPN7X+xivqMQCYQuOI2Norg5iOCn0DgjzGxv04SGi10b4ebx/eWOgtUG0zBssfyNUJeRGfT0y9EW87ce+tv82SSg1BkG3VQIxwSXU0ndkLT6cAxPjmEY+s60Gg3a/7GBG5H/juYWNBS9FGCkVCvdX6cmnfkYwVtHmYebFNnJkMDkDfHAc6m5+BFF30ynI8u0w0bBOJxK6zGpjpqpKBtmGJdN7vFLYfpNtPwSvtNVr1G+VCFRpIfXEpp+8jQDA9NzWMqh0iF44au7BvQitGVL/qil0xKoJNhyKdBccZnl6BbkLjwHOiC8h2p/w3B2Do1Rh1O5Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WkQk/AxBoNynt2TDj8lyZvznKA5x7L2TqvGLBS4oOXnZk033hoO3NI9lrF+zNp6R53f8rwEuV/cU/f28wizdZUARjFuGDaZhEmPflSlOaiiShymip6waQatsaAL+9cEnV1FVh9+gvFwh0mYl5AHb5HQASratz9Jf8F6rcLM+QQuOjXYuEKwhxlMLDBCRyQaKDZXj1qtmNEYsJic5iVTapeu6tc1OIvsMO8UsYJUS7Jk65U0c6L21QVC7ew6qkPN8biKNiu38y0Myo5PSNNCD/SzrHNo4anTT3e7r7qhyW+6YBecjvWJENpgYUI3UjMrv3KxTGhVwowcIDZCdv8Xkmw==
- Authentication-results-original: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Cc: Julien Grall <julien@xxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Rahul Singh <Rahul.Singh@xxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Fri, 15 Oct 2021 15:22:11 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXwcz8unryLt1qUEeMdpd7xMjDNavUKeYAgAABFACAAAGtAIAAAIKA
- Thread-topic: [PATCH v7 2/5] xen/arm: Enable the existing x86 virtual PCI support for ARM
Hi,
> On 15 Oct 2021, at 16:20, Stefano Stabellini <sstabellini@xxxxxxxxxx> wrote:
>
> On Fri, 15 Oct 2021, Bertrand Marquis wrote:
>> Hi,
>>
>>> On 15 Oct 2021, at 16:10, Julien Grall <julien@xxxxxxx> wrote:
>>>
>>> Hi Bertrand,
>>>
>>> On 15/10/2021 14:59, Bertrand Marquis wrote:
>>>> diff --git a/xen/drivers/passthrough/pci.c b/xen/drivers/passthrough/pci.c
>>>> index 3aa8c3175f..082892c8a2 100644
>>>> --- a/xen/drivers/passthrough/pci.c
>>>> +++ b/xen/drivers/passthrough/pci.c
>>>> @@ -766,7 +766,21 @@ int pci_add_device(u16 seg, u8 bus, u8 devfn,
>>>> list_add(&pdev->domain_list, &hardware_domain->pdev_list);
>>>> }
>>>> else
>>>> + {
>>>> +#ifdef CONFIG_ARM
>>>> + /*
>>>> + * On ARM PCI devices discovery will be done by Dom0. Add vpci
>>>> handler
>>>> + * when Dom0 inform XEN to add the PCI devices in XEN.
>>>> + */
>>>> + ret = vpci_add_handlers(pdev);
>>>
>>> Sorry for only noticing it now. Looking at the last staging
>>> vpci_add_handlers() is annotated with __hwdom_init. On Arm, __hwdom_init
>>> means the function will disappear after boot.
>>>
>>> However, pci_add_device() can be called from a physdev op. So I think we
>>> would need to drop __hwdom_init. I can't seem to find this change in this
>>> series. Did I miss anything?
>>
>> Good catch and not this is not in the serie.
>>
>> Can we consider that a bug so that I can send a new patch or should I send a
>> v8 ?
>
> We don't typically do that, but I could make the change on commit, or
> merge a second patch from you with this one on commit, after I run all
> the gitlab-ci tests.
Thanks but we need to sort out the where first (Julien’s mail).
I guess a v8 will be required.
Cheers
Bertrand
>
> (I still have to read the series but FYI)
|
