[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/9] scsi/sd: add error handling support for add_disk()
- To: Luis Chamberlain <mcgrof@xxxxxxxxxx>
- From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
- Date: Sat, 16 Oct 2021 22:51:48 -0400
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Pl/XfbWyXkO9WxOahSYpg/veQLO34KTMKHuf1fPJlq8=; b=nnqS5R26xbyePPq72qzvymPOo1lbWOdLzbPeRmeFkTgcD7SNXBYz1FgidtxeRbK74r/hwHNB0TDAh37PfqbEVYuIZJSvOhgPRBcR2bLiE9sKVlFw8O/opsQLam5a29Z0RVBg4sLH9OzFwiR4Fsoi9ncp7xr9t7Ez8TcHDc7xCwHv1eQGVukb9pFH7hGX4tva3mbkvHzmIhp4KbsVpjWE8WK/VJ5KolPxcbpyWm+uJJzaieFbNkPdd5kps8VmUP4ZFpcQst7YIaEIhfFm5oq0++JmN+e3cBbL24lFxfaXba0WCE4ULVD/AlQnHRpAzi71FfP3VQAbXEbi/FFM04ShAQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YNJ9tEeVny6bJG1CtMZsR5mFoJuDAKQgkXf+GMg84r5if0jwscRKFtLC0lH5aghZbStV1/XZyKWOjCPpdBpOs8OQLs9DWDB2DpxKfyA9S1NWJZEPQjFSvr3W82u0+d+jonOh0IAdeL85FqPqMpuFpMHftMfa7sxtMaAbximweZTzb6S/B+5BKjFmm8pnr0R/6STyp3cJIRBPRKtrcpEhVSXp4aylp3P64xsI8VJBMozCyCkORVu9ebMPHVdAQxzpBtuiOCFJvvgRW4yTOHuHAq0fOcwfE2V+7N2em0XPTpnPB+hp3nIJla4+1jnnmFpGDrstkebUsd4XQJB+WXHz9w==
- Authentication-results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=oracle.com;
- Cc: axboe@xxxxxxxxx, jejb@xxxxxxxxxxxxx, martin.petersen@xxxxxxxxxx, agk@xxxxxxxxxx, snitzer@xxxxxxxxxx, colyli@xxxxxxx, kent.overstreet@xxxxxxxxx, boris.ostrovsky@xxxxxxxxxx, jgross@xxxxxxxx, sstabellini@xxxxxxxxxx, roger.pau@xxxxxxxxxx, geert@xxxxxxxxxxxxxx, ulf.hansson@xxxxxxxxxx, tj@xxxxxxxxxx, hare@xxxxxxx, jdike@xxxxxxxxxxx, richard@xxxxxx, anton.ivanov@xxxxxxxxxxxxxxxxxx, johannes.berg@xxxxxxxxx, krisman@xxxxxxxxxxxxx, chris.obbard@xxxxxxxxxxxxx, thehajime@xxxxxxxxx, zhuyifei1999@xxxxxxxxx, haris.iqbal@xxxxxxxxx, jinpu.wang@xxxxxxxxx, miquel.raynal@xxxxxxxxxxx, vigneshr@xxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
- Delivery-date: Sun, 17 Oct 2021 02:52:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
Luis,
> We never checked for errors on add_disk() as this function returned
> void. Now that this is fixed, use the shiny new error handling.
>
> As with the error handling for device_add() we follow the same logic
> and just put the device so that cleanup is done via the
> scsi_disk_release().
Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
--
Martin K. Petersen Oracle Linux Engineering
|
