[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/9] scsi/sd: add error handling support for add_disk()
- To: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, axboe@xxxxxxxxx
- From: Luis Chamberlain <mcgrof@xxxxxxxxxx>
- Date: Mon, 18 Oct 2021 13:31:53 -0700
- Cc: jejb@xxxxxxxxxxxxx, agk@xxxxxxxxxx, snitzer@xxxxxxxxxx, colyli@xxxxxxx, kent.overstreet@xxxxxxxxx, boris.ostrovsky@xxxxxxxxxx, jgross@xxxxxxxx, sstabellini@xxxxxxxxxx, roger.pau@xxxxxxxxxx, geert@xxxxxxxxxxxxxx, ulf.hansson@xxxxxxxxxx, tj@xxxxxxxxxx, hare@xxxxxxx, jdike@xxxxxxxxxxx, richard@xxxxxx, anton.ivanov@xxxxxxxxxxxxxxxxxx, johannes.berg@xxxxxxxxx, krisman@xxxxxxxxxxxxx, chris.obbard@xxxxxxxxxxxxx, thehajime@xxxxxxxxx, zhuyifei1999@xxxxxxxxx, haris.iqbal@xxxxxxxxx, jinpu.wang@xxxxxxxxx, miquel.raynal@xxxxxxxxxxx, vigneshr@xxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, dm-devel@xxxxxxxxxx, linux-bcache@xxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, linux-m68k@xxxxxxxxxxxxxxxxxxxx, linux-um@xxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, Christoph Hellwig <hch@xxxxxx>
- Delivery-date: Mon, 18 Oct 2021 20:32:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Sat, Oct 16, 2021 at 10:51:48PM -0400, Martin K. Petersen wrote:
>
> Luis,
>
> > We never checked for errors on add_disk() as this function returned
> > void. Now that this is fixed, use the shiny new error handling.
> >
> > As with the error handling for device_add() we follow the same logic
> > and just put the device so that cleanup is done via the
> > scsi_disk_release().
>
> Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Thanks, would you like Jens to pick this up and the other scsi/sr patch
or are you taking it through your tree?
Luis
|
