[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/CPUID: don't shrink hypervisor leaves
- To: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 18 Oct 2021 13:45:29 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DcYuhL0Sw6ybNQmZXVMzlvwa2CaGB10Vwt71/KMmJss=; b=PaaWC+ZpnmE5w0rf7jhig7WzqtEYdJBteDgkaQd2q+Xz3yMI29Yr0G/QFhlIOHJN6YXhHUNYWPIVZdy6xU7I52vd98bOu3+i174uwAUd0T7ex3yg4ZKwWMy31CJ52Ww5a32lxgNDblhQzMpmeHK1v1ETQVtSSr2PmGENHtmUQpVyqqNnsGMXPK90cmCUe8HJ5DZyfCg5rl+p9WcnXvJ+jO2Qrv3xf/xZKd4NsGz8pdnxh61yrVi80b9LDwsB8kGHLPWdpH2/GOHA+Xc/q+3/a+ua3bMVtjujefv1UzUpjtXdo8BGHZ1YLNl2BDcaRqwqWmFh0Tu0431McFUDN8MMMw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XfHkCbKCJnO6Q8QuM+fitZu0OV9LwLtI+VcdZeeqHimNNA41qhVG7KvelL0xiYUZ2P+WSCfpOv96yMT24YzZBnG5eTbDqCPtE3EDOb1fvmwygBGBzETpBWWcvqVN4SuE8llKAEPSg2rwMApaXwa538km0dUMwmqYoDdxNSg5W9jaOcYS/O3Ywled/JBBNW+oSsSZct6V+S+k69uHco0hdKktNG5gjq5QjJXevzqsJe+OTXqWyZCsiN6Dj99fGMKnl5oSDprVOYHhETd/ZtpXmO6BNaNetefCJeZ/op2Kwo0Q1b3A738SC4kfStcb1KF8o/igh2ElEBWHN6lvicAt4w==
- Authentication-results: esa6.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Mon, 18 Oct 2021 11:46:17 +0000
- Ironport-data: A9a23:ZMU/eqKV/xfW4ik6FE+RCpIlxSXFcZb7ZxGr2PjKsXjdYENShDUEz WZOWGmGM/jZazSmKogjbI62/BgFsJKEn4RnHVNlqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokcxIn5BC5C5xZVG/fjgqoHUVaiUZ0ideSc+EH140Eo6y7Zg6mJVqYPR7z2l6 IuaT/L3YDdJ6xYsWo7Dw/vewP/HlK2aVAIw5jTSV9gS1LPtvyB94KYkDbOwNxPFrrx8RYZWc QphIIaRpQs19z91Yj+sfy2SnkciGtY+NiDW4pZatjTLbrGvaUXe345iXMfwZ3u7hB2Vx/5W4 +xL6qX3SCwGYLOSlMUmbRZXRnQW0a1uoNcrIFC6uM2XiUbHb2Ht07NlC0Re0Y8wo7gtRzsUr LpBdW5LPkvra+GemdpXTsF2gcsuNo/zNZ43sXB81zDJS/0hRPgvRo2XuIMBhmtg16iiG975R /Ufdh1SaijtOR9SHQwlD708uqSn0yyXnzpw9wvO+PtfD3Lo5BN1+KjgNpzSYNPibdVYmAOUq 3zL+0z9AwoGL5qPxDyd6HWui+TT2yThV+o6Fre16/pri1273XEIBVsdUl7TnBWiohfgAZQFc RVSo3dw6/hpnKC2cjXjdwHgjlmvhxhDYp1ROMJk9l+B65Hq7AnMUwDoUQV9QNAhscY3Qxkj2 VmIg87lCFRTjVGFdZ6O3uzL9W3qaED5OUdHPHVeFVJUvLEPtalq1kqXJuuPBpJZmTEc9dvY+ DuNsDQlz4saicoGxs1XFniW3mry+PAlouMzjzg7v15JDCskPOZJhKTysDA3CMqsyq7DHzFtW 1Bfw6CjABgmV83lqcB0aLxl8EuVz/iEKibAplVkAoMs8T+gk1b6I9sMvGAjdR01bpxVEdMMX KM1kVkAjHO0FCDyBZKbnqrrU5h6pUQePYWNug/ogipmPcEqKV7vENBGbk+MxWH9+HXAYolkU ap3hf2EVC5AYYw+lWLeb75EjdcDm3BvrUuOFMuT50n2jtKjiIu9FO5t3K2mNbtisstpYWz9r r5iCid9404DCbKjPnSOrNd7wJJjBSFTOK0aYvd/L4arCgFnBHsgG7nWx7YgcJZihKNbiqHD+ XTVZ6OS4AGXaaTvJVrYZ3Z9RqnoWJoj/3s3MTZ1ZQSj2mQ5YJbp56AaLsNlcb4i/e1l7Ph1U /haJJnQXqUREmzKq2YHcJ3wjI1+bxD31wiACDWoPWokdJl6Sg2XptK9Jlnz9DMDBzacvNclp +HyzRvSRJcOHlwwDMvfZP+14Um2uHwRxLB7U0fSe4EBc0Tw6ol6bSf2i6Zvcc0LLBzCwBqc1 hqXXkhE9bWc/ddt/YCQ166eroqvH+9vJWZgHjHWveSsKC3X3mu/2oscAuyGSi/QCTHv86K4a OQLk/ylaK8bnExHupZXGqpwyf5s/MPmorJXw1g2HHjPaFj3WLpsLmPfgJtKv6xJgLRYpRG3S gSE/dwDYeeFP8bsEVgwIgs5b7vciaFIy2eKtfllcl/n4CJX/aacVRQANhaBvyVRMb9pPd532 uwmosMXt1SyhxdC3gxqVcyIG7Bg9kA9bpg=
- Ironport-hdrordr: A9a23:W9dgcqinqfDuFAR7lPCo1AvAq3BQX0F13DAbv31ZSRFFG/FwyP rAoB1L73PJYWgqNU3I+ergBEGBKUmskqKdxbNhR4tKPTOWw1dASbsN0WKM+UyDJ8STzJ856U 4kSdkCNDSSNykFsS+Z2njALz9I+rDum8rJ9ISuvkuFDzsaE52Ihz0JdTpzeXcGIjWua6BJcK Z1saF81kadkDksH46GL0hAe9KGi8zAlZrgbxJDLxk76DOWhTftzLLhCRCX0joXTjsKmN4ZgC T4uj28wp/mn+Cwyxfa2WOWx5NKmOH5wt8GIMCXkMAaJhjllw7tToV8XL+puiwzvYiUmRsXue iJhy1lE9V46nvXcG3wiRzx2zP42DJr0HPmwU/wuwqrneXJABYBT+ZRj4NQdRXUr2A6ustn7a 5N12WF87JKEBLphk3Glpn1fiAvsnDxjWspkOYVgXAae5AZcqVtoYsW+14QOIscHRj99JssHI BVfY/hDc5tABCnhk3izytSKITGZAV3Iv7GeDlMhiWt6UkXoJgjpHFogPD2nR87heQAotd/lq P52gkBrsA6ciYsV9MPOA42e7rBNoX8e2O9DIusGyWUKEgmAQOEl3el2sR/2AmVEKZ4uKfa3q 6xFm9liQ==
- Ironport-sdr: JBnknY3CC1V97fTmYGZpkXQwL6u5AtuVBTNzHzWgp9VdRks3E6zbAzkOTh1Oddo2Q6rAiUEnLv sA+g7SbAYJ/ywfE9SWHmnnc/PPGkFA4cTKW19MUmZ0IH0HhA2cR239vPh4ZKNx5E+qyHWSzErJ oNa3+5PDbm+k+MTcY7N1MTJIRBV8ORS2L6xVx+9cmejlZikd/nrzjMOQVpz8EC0V56HPoTpAdO l6wB2Y9MJNLW9iO06zCuLDVyvybXAm6UNqnsHukJGGl+WtyoTNzaW7xc0nRq72VdGen919KhfX DqJYxsE8K4NKea/KqTSnFg0h
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Fri, May 07, 2021 at 10:40:34AM +0200, Jan Beulich wrote:
> This is a partial revert of 540d911c2813 ("x86/CPUID: shrink
> max_{,sub}leaf fields according to actual leaf contents"). Andrew points
> out that XXX.
>
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> ---
> Obviously the XXX wants filling in. So far I did not really understand
> what bad consequences there might be, but I can agree with the undoing
> of this part of the original change along the lines of why the Viridian
> side adjustment was also requested to be dropped (before the patch went
> in).
I have to admit I'm confused about this. Here the maximum leaf
reported only changes between PV and HVM, but never as a result of the
features exposed, which I think should be fine?
Ie: I recall the problem being the maximum leaf possibly shrinking
when migrating, but that's not the case.
Thanks, Roger.
|