[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/CPUID: don't shrink hypervisor leaves


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 18 Oct 2021 14:09:24 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GLWj5tMXlfRChWV9sYQaDGrsPtFEhU0wkmDjqZ+8xdg=; b=oR2dd9Ma0CoMkA4TFeOKivyXXFAjgPLyXA6QHW9ItoreDmPyWo6E0VJLJ3/FFJKAzpIMIe0C6xArpPv5qQXg2yHd4JNoR6iz4sXyc7zimo3L8H9CQUSPKs4xel90c1pWMPchgKcnBOFwNjny9ArDX/A2AXWSk3w5IBdw+zBl6vVk0iEqqED/pJ1PqWpVG2aHz+TWYL4YDKvxrYHY1daAujDSuvNjNZNs6uV+oHCBeA6WgwpjJKuwkJVb3V2U7VpKPTUdXWA/ZEWFKLqVOlF8UFSrp+Uw/kkVcOnCUqxzCLwoe05I5zIsf19M3x2w1CfvSplYmOmSfbleByfWJicp5A==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fJUCz301ofHHv45y6zOhwHgyxmJIksUYJ/q7Mp584x/xRTYFCLrqZKfUpiKW0oaJzTCc5pK6tHcRoeUIHZ8uadSBnYlQFgzfnFjhy7ynt7s24roGxUcGo+B9jlEgm5OYP4yqjAKFF1wX1jktlK5ah4f4MuDHRDE4ywDP4YlQkHi/nFAlwhPlfqQYgZuC/0PaIjAxNX73l8rNPt82e2bbq+df7Gh2Qo/Nalb7Mo0P7mKGXAQM6u0K181tl97YAHU6AUvRFKZg60rtO4779IxrnsWb409zn3udo8rk0+56Vz7shxgQPbFqPED49vcBLC0cN55Q3qiyFdGL1/Pw7UQavg==
  • Authentication-results: xen.org; dkim=none (message not signed) header.d=none;xen.org; dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
  • Delivery-date: Mon, 18 Oct 2021 12:09:36 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 18.10.2021 13:45, Roger Pau Monné wrote:
> On Fri, May 07, 2021 at 10:40:34AM +0200, Jan Beulich wrote:
>> This is a partial revert of 540d911c2813 ("x86/CPUID: shrink
>> max_{,sub}leaf fields according to actual leaf contents"). Andrew points
>> out that XXX.
>>
>> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> Obviously the XXX wants filling in. So far I did not really understand
>> what bad consequences there might be, but I can agree with the undoing
>> of this part of the original change along the lines of why the Viridian
>> side adjustment was also requested to be dropped (before the patch went
>> in).
> 
> I have to admit I'm confused about this. Here the maximum leaf
> reported only changes between PV and HVM, but never as a result of the
> features exposed, which I think should be fine?
> 
> Ie: I recall the problem being the maximum leaf possibly shrinking
> when migrating, but that's not the case.

I assume that's a question to Andrew? Because if I knew the answer,
I could probably have written a proper / complete description.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.