[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Ping: [PATCH] x86/altp2m: don't consider "active" when enabling failed
- To: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 19 Oct 2021 09:45:30 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sz4VozwYbHuZn93oK1so7+q4bf1ox0W13ZwCcLXmpao=; b=Hzj8Km7bL1IeS7JhFs4dZO9G/2sfMfkL6KBTnHGBaAD5+df2CmdYsPqblWVscDzVtblz1MXF9AWGQ0RALtjQRkQ83Ch10u8s3sYLei2P98bGN1pRudjXOVwKHp9+N4zlcSnt0Omkc0/PQOmbnB7cpmwxMZOR6g08g8eD2zS5pV6OhCzrm56HeNVW7/hQCQgFSPChx0IS/4kIOUowfUM2gvaa49Mfbu4xU44YKB3rDaAtdmJI/nxNzXPBNg4K8KRVqtrMqnl4HJ2HjarJ46l+AHNlMiPADHJC3E9mFTCo1+h54scdWJSaNWThcG0nlVAGOKWjlXXlWZmsse34BxORsw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ayZblKb7YRgsl3YwDd5uWX9AwayQSGWzewf51pqNCX3zP2+19lejeu1Z065B917JLl7LY6C05/Vl4Lg3telpDBbXJvzKRvnZybje14PMUPnJckPLRLCg1qKO09knX1Vr2KnRLrMQUQeYGzz0JlR5q/gB/iEDUe5FMOnT9jcNQZSnCA2teLr8yKUwTHy5FuilfK8Ah0XWciKieWqVKKt5HO4QD/ERj+OEVGqFrvRfwjmkwMLEmDYjZf7Vz1fwM6PFvA5GXJXwOL7//HabkIOORTlpVvQJiy8B9JMWI0InLFJw1HUxXeMVLUJ6udJLJW5CNbGLxq7WVEZ526oSMpfGeg==
- Authentication-results: esa4.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Ian Jackson" <iwj@xxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>
- Delivery-date: Tue, 19 Oct 2021 07:46:10 +0000
- Ironport-data: A9a23:3Thg3K6J9LcLWJfgmmIPLwxRtJLAchMFZxGqfqrLsTDasY5as4F+v jQXCGyEM/+CZmbwc952bITl/U8O78TXmtdhSwRo+XsxHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVIMpBsJ00o5wrdh298w2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Zk dZB64fvQAUQPrDrwdo0TDAEAnF5BPgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWhs3pwfQKm2i 8wxSmVLMBjlZj1zJl4OErkXnsHzuEKgWmgNwL6SjfVuuDWCpOBr65DsL9j9atGMXd9SnEuTu iTB5WuRKgkCNcaUwD6M+G+EjO7TkS71VYQeGaf+/flv6HWax3caCRkffVG6vfW0hEO4V99Fb UcT/0IGsaE3/VeDUtr5Uhu3sXOA+BUbXrJ4Eec39QWMwar8+BuCCy4PSTspQMwrsoo6SCIn0 neNnsj1Hnp/vbuNU3Wf+7yI6zSoNkAowXQqPHFeC1Ffup+6/d913kmnostf/LCd1975Ryqvy jKzrDUZ3os6kudXxvW8xAWS696znaThQgkw7wTRe2uq6AJleYKoD7CVBUjnAeVod9nBEAHQ1 JQQs43HtrpWVMDS/MCYaLxVROnB2hqTDNHLbbeD9bEa/DOx52XrQ4lU5DxvTKuCGpdZIWG3C KM/VAU42XOyAJdIRfMoC25SI55zpUQFKTgDfqqEBjapSsMpHDJrBAk0OSatM5nFySDAa50XN 5aBatqLBn0HE6lhxzfeb75DiuN2lnpgnTmNHMCTI/GbPVy2Pi79pVAtawPmUwzExPnc/FW9H yh3ZqNmNCmzoMWhO3KKoOb/3HgBLGQhBICeliCkXrXrH+aSI0l4U6W56ep4I+RNxv0J/s+Vr iDVchIJkzLX2CyYQThmn1g+MdsDq74k9illVcHtVH71s0UejXGHvP5OKcpnI+N5nAGhpNYtJ 8Q4lwy7Kq0nYhzM+igHbIm7q4pndR+xghmJMTbjaz86F6OMjSSTkjM9VgewpiQIEAStss4y/ ++p2g/BGMJRTAV+FsfGLvmoygrp73QanetzWWrOI8VSJxqwoNQ7dXSpg69lOdwIJDXC2iCei 1ScDyAHqLSfuIQy6tTI2/yJ9t/7D+tkE0NGNGDH9rLqZzLC92+uzNYYAuaFdDzQTk3u/6Cma bkHxv3wKqRfzl1Lr5B9A/Bgyqdnv4njoLpTzwJFGnTXbgv0VuM8cyfehcQW7/9D3L5UvweyS 3mjwNgCNOXbIt7hHX4QOBEhMraJ28YLl2SA9v8yOkj7unN6peLVTUVIMhCQoyVBN78pYpg9y OIstcNKuQyyjh0mboSPgixOrjneK3UBV+Mst40AAZ+tgQ0ukwkQbZvZAy7wwZeOd9QTbRV6f m7K3PLP1+ZG207PU3svDnycj+NSiKMHtA1O0FJfdU+CncDIh6Nv0RBcmdjtot+5EvmTPzpPB 1VW
- Ironport-hdrordr: A9a23:n3w5xqr3yVkcNmQ1q79YrSAaV5u4L9V00zEX/kB9WHVpm5Oj+f xGzc516farslossREb+expOMG7MBXhHLpOkPQs1NCZLXXbUQqTXftfBO7ZogEIdBeOk9K1uZ 0QF5SWTeeAcmSS7vyKkDVQcexQuOVvmZrA7Yy1ogYPPGMaGJ2IrT0JcTpzencGNTWubqBJba Z0iPA3wAZJLh8sH7qG7zQ+LqT+juyOsKijTQ8NBhYh5gXLpTS06ITiGxzd+hsFSTtAzZor7G CAymXCl+uemsD+7iWZ+37Y7pxQltek4txfBPaUgsxQDjn3kA6naKloRrXHljEop+OE7kosjb D30lgdFvU2z0mUUnC+oBPr1QWl+DEy60X6wVvdunfnqdyRfkNwN+NxwaZiNjfJ4Uspu99xlI hR2XiCipZRBRTc2Azg+tnhTXhR5wmJiEtntdRWo21UUIMYZrMUh5cY5llpHJAJGz+/wJw7Ed NpENrX6J9tABOnhkjizyxSKeGXLzAO9k/seDlEhiXV6UkWoJlB9Tpb+CRF9U1wsq7USPF/lq z52+pT5ehzpmJ/V9MLOA47e7rDNoX6e2OEDIujGyWUKEg5AQO4l3fW2sR+2Aj4Qu1E8HMN8K 6xJm+w81RCI37TNQ==
- Ironport-sdr: COHYvfMboBdCf91H+pn7u6lVfECoIG8Hro3ysJFb5BI6NZNi2TaSf5IkmCjd42cuRK2WQwE7OE oTSSCX1EQN14Lqv4YpVS/DfxswE1T5jWRN6fuy/7PDPKxoqQMeeX+9QnCPLcWvrV/sSYAVLoU0 F1wTu/l6pVZUIBg2rHi9o21jMhY9MSq+0TgXRczrWN3YgRE/5T+4T6vA+W3Ew8RQLmndtXRFEV MK+I1IxWxrhf+yIi7DqOCTAnf6sVLcpnFjefcoO1RGT0VZLkXZP+6Tb3CXrJ2EC3kFJcFDRsb/ FZ70yimKGJRrDQNEX5dnAmBs
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Oct 18, 2021 at 09:16:30AM -0400, Tamas K Lengyel wrote:
> On Mon, Oct 18, 2021 at 4:26 AM Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> > On 25.08.2021 11:31, Jan Beulich wrote:
> > > We should not rely on guests to not use altp2m after reporting failure
> > > of HVMOP_altp2m_set_domain_state to them. Set "active" back to false in
> > > this case.
> > >
> > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> >
> > Because of their relationship, I'm also Cc-ing the vm-event maintainers /
> > reviewers: Maybe one of you would care to review this one?
> >
> > Jan
> >
> > > --- a/xen/arch/x86/hvm/hvm.c
> > > +++ b/xen/arch/x86/hvm/hvm.c
> > > @@ -4609,6 +4609,8 @@ static int do_altp2m_op(
> > > if ( ostate )
> > > p2m_flush_altp2m(d);
> > > }
> > > + else if ( rc )
> > > + d->arch.altp2m_active = false;
> > >
> > > domain_unpause_except_self(d);
> > > break;
>
>
> Reviewed-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
