[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/3] Fixes: PCI devices passthrough on Arm


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Tue, 19 Oct 2021 13:25:47 +0200
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ga5BNlOutqG/yZYHaC+o3yjkXEU0eKgcGY/4M3UFTZ0=; b=NpQnGCsLX4EzuFtNtY8E04wVTDrsqZ4VgZU2C1xBY2+KnRf1O6OUDbLVhs125z1szQ4jSTb8sPgvBfRmxYpQe3SXvyIrE+K9thP8+nMsbgNz0x9s+z5THbFFmqLOc1YZi0qa84zGC1q2sDfI1DrT7Z6D34WYEfbs2n5Kn2pqGtLqCH5BzB+4SvxmEArR4wY9MJgu0ziqA3sehc0PlBMDOHGT0iWbeaYTQtBT+ghgvsCJx2XAk0gfQ7DNmCdNqL22LSGxno5jmSeC4dfPgRiqi1GzaH9Rn/TXGl2KisV1b3c8PomaMpmuDlKAy2OjaNjlnWpFuUjITa34MZfkGwRm+g==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=C9nquac0T2BEmGMFm2TgYGW05DBsJmNzTsMJ2dhqkFSt6QM5mavR37+9nHWBFfHbQ22wt6yhBCWzND3Sb31McQ8yBM6WwnvR/Gr49g3SVWATB41i8/brQJppYpb4brtLS9UR2bguhFnD3y4WF+U+79WKAVxNPSWotUrOwKV2GyirIZfJVZ95OrF1FHhr8YMXGoBaB9bD1ntk1+IIqbvNCmzUCZED7maz4hJSd3RWMr+8nN3o3bqw+XevUweoRBO5Qk1siOnxtwXxSk79LzLzdSSXuRw57sBf16Ko3TVdOZ/beZasl7c+DNbh/YALpHwkrcjXJwtur5Bo0FHa2Gqozg==
  • Authentication-results: citrix.com; dkim=none (message not signed) header.d=none;citrix.com; dmarc=none action=none header.from=suse.com;
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxxx, Bertrand Marquis <bertrand.marquis@xxxxxxx>, sstabellini@xxxxxxxxxx, Oleksandr_Andrushchenko@xxxxxxxx, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Tue, 19 Oct 2021 11:25:55 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 19.10.2021 13:12, Ian Jackson wrote:
> Bertrand Marquis writes ("[PATCH 0/3] Fixes: PCI devices passthrough on Arm"):
>> This patch serie is a follow-up after various findings on d59168dc05
>> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
>> agreed in [1].
>>
>> It does the following:
>> - enable vpci_add_handlers on x86 and not only on arm
>> - remove __hwdom_init flag for vpci_add_handlers
>> - add missing vpci handler cleanup in error path during pci_device_add
>>   and pci_device_remove
> 
> Thanks.  Roger, Jan, what do you think of this ?

I'll get to this, but at the first glance I'd say that the change in
patch 1 coming before what patch 2 does is already a problem.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.