[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Bertrand Marquis <Bertrand.Marquis@xxxxxxx>
- Date: Tue, 19 Oct 2021 11:32:38 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dKrQOCyDCw3CZ4gHOudlzVOYZ0BMoOJTHY6Yunl+J0s=; b=i6mLHAWYIuvF8d0CLJRYiWBrzQtJzteEkfm513Mucde5xuERh6SODGCWrIE/DJX1yq5uBsEt+ti6I424Y/RWd+HrdXTdj81EdvVeT7zIFrJO4m49OzFaCjR425qb4cnmX6MxfX2IJHNEMWstdN3TZlLF/kHSJAxZZRhiJ418gx6aHSlW2F0r7O4DA8gXSjK3y60gUpU61id5AoKet7/noUnPoXfYybbckMJCKvopOHlO6YhS0bD/pYIAqnn9z8bM96oYvCTIGMfTQGpUAfycbKaaELkwVqemde4BBOstA7X8CALM7cqCEcRKHP7IAkWPTAe/30I0Hx8vDea1z3NbmA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FSiaQqRnMFKgHi0bu84Knw6kqTjqamazJJPjZisNMDD/l2622cY9mBIrbuOyt35aLvvJeS+FjvTS9UPu7zuQM5BY0oxKuSjDAKmdvWLpzXYihgzLYx+3eErcY+RmQdkO9TfUvAIGqiuAOCCkx+KHigv8S5m0jmD84gDvnC4ww0YC+R4lh8shxtDh15RNx9w0LiWsCPO0rfyKw9gL3payTS6Fzt/NhLfa8xIyzs1VOvV/eJLMfb0EVt49SFSZtVv2RoVCxc36v8Dq//pB3KFxVKf+gK2ToqFIMuaQSci7AKnNLwdZquF35Am6aBtYwnHuB7muj9CdNaozXSnkcOzfYw==
- Authentication-results-original: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Cc: Ian Jackson <iwj@xxxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, "Oleksandr_Andrushchenko@xxxxxxxx" <Oleksandr_Andrushchenko@xxxxxxxx>, Paul Durrant <paul@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 19 Oct 2021 11:33:34 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: suse.com; dkim=none (message not signed) header.d=none;suse.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHXxNXsWVtDOu3dTEyPepRQ+pXuJKvaKrkAgAADu4CAAAHpAA==
- Thread-topic: [PATCH 0/3] Fixes: PCI devices passthrough on Arm
Hi Jan,
> On 19 Oct 2021, at 12:25, Jan Beulich <jbeulich@xxxxxxxx> wrote:
>
> On 19.10.2021 13:12, Ian Jackson wrote:
>> Bertrand Marquis writes ("[PATCH 0/3] Fixes: PCI devices passthrough on
>> Arm"):
>>> This patch serie is a follow-up after various findings on d59168dc05
>>> ("xen/arm: Enable the existing x86 virtual PCI support for ARM") as of
>>> agreed in [1].
>>>
>>> It does the following:
>>> - enable vpci_add_handlers on x86 and not only on arm
>>> - remove __hwdom_init flag for vpci_add_handlers
>>> - add missing vpci handler cleanup in error path during pci_device_add
>>> and pci_device_remove
>>
>> Thanks. Roger, Jan, what do you think of this ?
>
> I'll get to this, but at the first glance I'd say that the change in
> patch 1 coming before what patch 2 does is already a problem.
Because path 1 is actually introducing a bug solved by patch 2, I should have
thought of that.
I can either invert those 2 (or actually put patch 1 at the end) or merge patch
1 and 2 together.
Bertrand
>
> Jan
>
|
