[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers
- To: Bertrand Marquis <bertrand.marquis@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Oct 2021 14:39:17 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T0nQ9XuYTAjbiAJ0Watq2DV5kmRmzqQrNUQSZ11A9vg=; b=WoonGhq1SG5bA/6PcyMX/z8iEDD/ncN7lROAGL92wd0oGD75a4C9CaMdQG3oEpV1CkFjdsl0dGLbWKG7fIuCzSWFryuBiFbyr6M29n3uUjcsTxox/TV6/h8NBZqUNqXm7vMtdd7MgO0YWLocPKuEws79RJke2ZnPjtSWN+I0n7g5wXnTWEab9wfT2J7Vjg02hINjRDH/08IByqRV4x6cnqEbehYE+WXtDZkFvl8io6DdfDtamsnqzWkMr/P/AP5hT/WPSp+0GQ0trc1DhxV31xZQXbBPNKFNRDsm68PYHsIF729JhfZEJVqk/4oObehbebUdNT49oAe7Q+H6TPOYpg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DVpgu9YsZtiUyoR+QA/WFi/E6uGcflqoxDR+QrJiR2/el5QrzWB6zVR0YwcpTv5In8f+lNEtXMY2k1RiStg9MdbXeGQrGZVYnNOoLcZusUb8TCMljv9GzhJe0lVTbRgkB3/7jQBjCUFc34FD2efJqKD4uYx7vJmhrt71VWUVhhOHkZusdVMwzBTY+xE4s5HYv9kPfQYO/NeCrX4iNIWyUVBowja68Df2kti7d21rcareOz+vWMrXh9iTE7Xlc2KI4e9naMjsMVx076nws2ZsUR5YCR1r1fnDWBN0H9WNpGCmGmJLDahM1Zgvo80ECf+MerUFNR7BwBFPbBlQyUcBjg==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: iwj@xxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, Oleksandr_Andrushchenko@xxxxxxxx, Roger Pau Monné <roger.pau@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 Oct 2021 12:39:30 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.10.2021 12:40, Bertrand Marquis wrote:
> --- a/xen/drivers/vpci/vpci.c
> +++ b/xen/drivers/vpci/vpci.c
> @@ -54,7 +54,7 @@ void vpci_remove_device(struct pci_dev *pdev)
> pdev->vpci = NULL;
> }
>
> -int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
> +int vpci_add_handlers(struct pci_dev *pdev)
A fundamental requirement when altering section attributes is to
also check that all referenced entities are appropriately placed.
Afaict this is not the case for __start_vpci_array[], and you'll
need to also adjust linker scripts to deal with that. Further
you'd have to check that all functions referenced by that array
aren't __hwdom_init. In taking an example (init_msi()) I'm
actually surprised to find it's not marked __hwdom_init. So
maybe all is fine as far as these are concerned.
Jan
|
