[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Tue, 19 Oct 2021 15:17:18 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LqMeKL7+IsnhaXtLhgzJzblM3JZ3BaIXMuZ2591rQdo=; b=oTxknLlVcxNFqoCAeuX2phzDXVUFdMphqX0NKaOe2x8AUPjLyo6GZgoNdKM9+2EfxYM3L2I3CznMTObrp0it4nKJZdaeNJHKsqRAjHjn8z0RAP63E9zpNEw/aAuSs9AtfWTMJ9DcvHoKmGLygtgucT+cEVwV8ZamJkBcQAzWUDXpJZPkphW2qFczKY3b6jKIMSenZcdf0luDR6vzXdL2MhZF3AKFUdFEaA8HaEvQi9FUXigrVM7gXeo3ge2/u4t4tyZ0bD3EEKOfERlcMQWrKJTPvaVKsJ3v6QvTFU16km9LGXgz/+sC3oyVDvQdgaZQ1uRv3ywjA9g7EoqTINDaeg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CWUbwaFBO4izLyTY3mhiXqUMLNaX6ffNA7kOl2EpYja3ZmDxKfoduvG4czXXkJqSGRRJourSUfyCBMPhuHBccWE9MRM7ccPiTpVwcV0hEcgfvMnOyZVX89yO8D7ctj/6C1wZV2Jo7m2I6/eI017MCVkd7XxS0gGb5K8rHgcy4C3V3UINiiUOuUn+I+elxlu/u0iQfYUrOqM/emNhzypTVV6xQXADPvlmI6OMHzE7sfU/jRhFSd7KBo5MPznBc4zE3fYsnqaff8KzPhd2AcyTMSsG5DgZZsobuyGbGvdnc4HE1UCOU1vRctWI0ydfhUfSqLCqhg3jbdApF+TwjHK3sA==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>, <iwj@xxxxxxxxxxxxxx>, <sstabellini@xxxxxxxxxx>, <Oleksandr_Andrushchenko@xxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 19 Oct 2021 13:17:41 +0000
- Ironport-data: A9a23:z2JaQaP/nCz+AvzvrR0ZkMFynXyQoLVcMsEvi/4bfWQNrUohhjdUz WdLCmvUb/vfYGKgct8gb4Wx9E4DscfQz95rTAto+SlhQUwRpJueD7x1DKtR0wB+jCHnZBg6h ynLQoCYdKjYdpJYz/uUGuCJQUNUjMlkfZKhTr6bUsxNbVU8En540Usyw7VRbrNA2rBVPSvc4 bsenOWHULOV82Yc3rU8sv/rRLtH5ZweiRtA1rAMTakjUGz2zhH5OKk3N6CpR0YUd6EPdgKMq 0Qv+5nilo/R109F5tpICd8XeGVSKlLZFVDmZna7x8FOK/WNz8A/+v9TCRYSVatYo261mst22 f9rjJq9cgEQM62UorUfehYNRkmSPYUekFPGCX22sMjVxEzaaXr8hf5pCSnaP6VBpLwxWzsXs 6VFdnZdNXhvhMrvqF6/YvNrick5atHiIasUu216zCGfBvEjKXzGa/iXuIEEgmZs7ixINbHme ZUXVyVfVU2eaDlGZRA0MIIaguj90xETdBUH8QnI9MLb+VP71xdt2bLgNN7UfN2iRshPmEuc4 GXc8AzRJRUXN8eWzzafxVuqivXShiPwWI8UF7qQ++ZjhRuYwWl7IA0bUx63rOe0jma6WslDM AoE9yw2t68w+Ue3CN7nUHWQonSJoxodUNp4CPAh5UeGza+8ywyUHHQeRzhNLtkvrtYrRCcC3 0WM2djuAFRHsaKXYWKQ8K+OqjG/MjRTKnUNDRLoViNcvYOl+ttqyEuSEJAzS8ZZk+EZBxmr/ zWRqzkUoYwVgPUN7qi7pWqWgRuj882hohEO2i3bWWes7wVcbYGjZpC15VWz0cusPLp1XXHa4 yBaw5n2APQmSMjXznTUEbpl8KSBvq7daFXhbUhT847NHthH00WoepxM+3lALUNtP9dsldTBM RKL5105CHO+OhKXgU5Lj2CZV5tCIUvIT42NuhXogjxmOMgZmOivp3kGWKJo9zqx+HXAaIlmU XthTe6iDGwBFYNsxyesSuEW3NcDn35lmT6DH86jlUr+gdJygUJ5r59fYDNiichitMu5TPj9q Y4DZ6NmNT0OOAEBXsUn2dFKdg1bRZTKLZv3t9ZWZoa+zvlOQwkc5wvq6ep5IeRNxv0N/s+Rp y3VchIImTLX2CycQS3XOy8LVV8adcsmxZ7NFXd3ZgjANrlKSdvH0ZrzgLNnJOh5pbw9l6Aco jtsU5zoP8mjgw/volw1RZL8sJZjZFKsgwePNDCiez8xY9hrQAmhxzMuVleHGPAmAnXluM0gj aen0w+HE5MPSx47VJTdae61zkP3tn8YwbogU0zNK9hVWUPt7Ik1dHCh0q5pe5kBeUfZ2z+X9 weKGhNE9+PDlJA4rYvSjqeeoob3T+YnRhhGH3PW5KqdPDXB+jbx2pdJVeuFJGiPVG799Ki4S /9SyvXwbK8OkFpQ6tIuGLd316MuodDoouYCnAhjGXzKaXWtC69hfSbajZUe6PUVy+YA6wWsW 0+J9t1LApmzOZvoQAwLOQ4oTuWfzvVIyDPc2us4fRfh7yht8bvZDUgLZ0uQiDZQJadeOZ8+x btzo9Yf7gGyh0Z4MtuCiSwIpW2AImZZDvciv5AeRoTqlhAq2hdJZpmFUn3655SGatNtNEg2I 2DL2Pqe1uoEnkeSIWAuEXXt3PZGgcVcsR9H+1YOOlCVl4eXnfQwxhBQrWw6Qwk9Is+rCA6v1 ryH73FIGJg=
- Ironport-hdrordr: A9a23:/DRkBqvKkZoO2SxEvKXGOlya7skCkoMji2hC6mlwRA09TyXGra +TdaUguSMc1gx9ZJhBo7G90KnpewK6yXdQ2/hqAV7CZnichILMFu9fBOTZsl/d8kHFh4tgPO JbAtVD4b7LfCZHZKTBkXCF+r8bqbHtmsDY5pau854ud3ATV0gJ1XYHNu/xKDwReOApP+tcKH LKjfA32wZINE5nJfiTNz0gZazuttfLnJXpbVovAAMm0hCHiXeN5KThGxaV8x8CW3cXqI1SvF Ttokjc3OGOovu7whjT2yv66IlXosLozp9mCNaXgsYYBz3wgkKDZZhnWZeFoDcpydvfomoCoZ 3pmVMNLs5z43TeciWcpgbs4RDp1HIU53rr2Taj8A3eiP28YAh/J9tKhIpffBecwVEnpstA3K VC2H/cn4ZLDDvb9R6NqeTgZlVPrA6ZsHAimekcgzh0So0FcoJcqoQZ4Qd8DIoAJiTn84oqed MeQ/003MwmMW9yUkqp/VWGmLeXLzYO91a9MwQ/U/WuonlrdCsT9Tpc+CQd9k1wg67VBaM0o9 gsCZ4Y542mePVmGZ6VNN1xMfdfNVa9My4kEFjiaGgPR5t3c04klfbMkcAIDaeRCds18Kc=
- Ironport-sdr: aal6IIQK3Zr7GkymtztptSSGR83gaQCkHPWdLDVLQimWbYwadwc9s5GeRZARD49NQrApJUQvo+ GH9UiaxfzuKEdKpMNEvya+DampG5PY8wkV1uAv0/2Qc1KBmncQ0h1xktJ3IafTm35zaUtHjNVX 9Uy+a/86g4vVCEOgI8EjZPMY5mRSUCJzu8LLr1GB8zBJa35MT5Z9IKQImMsm23kfSaJC4ErJDk 9VZbB8E9s13q5k2tnxJYCWIDaXuwMbK+KigPJl/wzKQFSMfzxDbL7qAzec7g3+3g/n2PUf5M5m N9+Y9ypSQuRZxwE4Rl500Kip
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Tue, Oct 19, 2021 at 02:39:17PM +0200, Jan Beulich wrote:
> On 19.10.2021 12:40, Bertrand Marquis wrote:
> > --- a/xen/drivers/vpci/vpci.c
> > +++ b/xen/drivers/vpci/vpci.c
> > @@ -54,7 +54,7 @@ void vpci_remove_device(struct pci_dev *pdev)
> > pdev->vpci = NULL;
> > }
> >
> > -int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
> > +int vpci_add_handlers(struct pci_dev *pdev)
>
> A fundamental requirement when altering section attributes is to
> also check that all referenced entities are appropriately placed.
> Afaict this is not the case for __start_vpci_array[], and you'll
> need to also adjust linker scripts to deal with that.
Indeed, we need to just keep the CONFIG_LATE_HWDOM placement in
.rodata.
> Further
> you'd have to check that all functions referenced by that array
> aren't __hwdom_init. In taking an example (init_msi()) I'm
> actually surprised to find it's not marked __hwdom_init. So
> maybe all is fine as far as these are concerned.
My bad, I've forgot to mark the initializers used by
REGISTER_VPCI_INIT as __hwdom_init. I think there's no need for a
change there.
Thanks, Roger.
|
