[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] xen/vpci: Remove __hwdom_init for vpci_add_handlers
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 19 Oct 2021 15:20:20 +0200
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DwTV0RjdCW/IzWacBhTscGwXs8PtG7Jla/xu8yPl6x4=; b=FrAVaVsQNMvqgdawFt1+IznEtzXvG/jhSymS7EU71kOGqwWJNWufMI/X7GfYhcriIuRkJ8CTRXEPDu3FQa4ODGeHxenDuQX7e0wGGekKXEyMktf4EZn2f5bgXtZ1F01U5h2mTkTsOodKRIs7NkpQFPcplSorIxGuuB8OQV4vf2fTDwbFTnyehQyNAyj5yQf4cRTl3uMr7UKaZf98dkxuwEtug31jcNg9oz9rdisfNuq33odysk1Fsn40NT5DZB7QhtglkLkvXphSnsCzNb6GkB7LphcywfBHXKDkGOA4wa9sg9kLch9KFS7NVemcbFt/F/hgn8lrU6MhpCBU62iw0w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AAQ/NOvJq1CkUjEogxgRGiqWoIkgJjzEMC1PpuURZ7PQ+qV5R/f4ujtgzSzk2Xjvu4uB4JutCvHTWaSSHQ4X4lFpokgusCe1Ugbha1ihAGnGDaT9YFUJ14gSZ/vZpCVBkj9zXsvMfNb4OBrH3rUg/InfZb7wH8QpFV0xtFqbJWD9317c7N9VP+MHlSPWUDU0TGLj+JgZLDoREjt6ld6c8nrqQYi/Tv/nfljXD4XavByBqq17tmIzIpu0h+aEezdE9YnCzu/leJ/3GpIAmbRygmwfQH+Cjc3aw1eeb7ns2OHy8VVbCfpPihjwY/wKD9oxkQ7JI6NWGWyeWJRSus/qgg==
- Authentication-results: lists.xenproject.org; dkim=none (message not signed) header.d=none;lists.xenproject.org; dmarc=none action=none header.from=suse.com;
- Cc: Bertrand Marquis <bertrand.marquis@xxxxxxx>, iwj@xxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx, Oleksandr_Andrushchenko@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Tue, 19 Oct 2021 13:20:29 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.10.2021 15:17, Roger Pau Monné wrote:
> On Tue, Oct 19, 2021 at 02:39:17PM +0200, Jan Beulich wrote:
>> On 19.10.2021 12:40, Bertrand Marquis wrote:
>>> --- a/xen/drivers/vpci/vpci.c
>>> +++ b/xen/drivers/vpci/vpci.c
>>> @@ -54,7 +54,7 @@ void vpci_remove_device(struct pci_dev *pdev)
>>> pdev->vpci = NULL;
>>> }
>>>
>>> -int __hwdom_init vpci_add_handlers(struct pci_dev *pdev)
>>> +int vpci_add_handlers(struct pci_dev *pdev)
>>
>> A fundamental requirement when altering section attributes is to
>> also check that all referenced entities are appropriately placed.
>> Afaict this is not the case for __start_vpci_array[], and you'll
>> need to also adjust linker scripts to deal with that.
>
> Indeed, we need to just keep the CONFIG_LATE_HWDOM placement in
> .rodata.
>
>> Further
>> you'd have to check that all functions referenced by that array
>> aren't __hwdom_init. In taking an example (init_msi()) I'm
>> actually surprised to find it's not marked __hwdom_init. So
>> maybe all is fine as far as these are concerned.
>
> My bad, I've forgot to mark the initializers used by
> REGISTER_VPCI_INIT as __hwdom_init. I think there's no need for a
> change there.
Not anymore, indeed. And less code churn now as a result.
Jan
|
