[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] osstest: explicitly set either enable or disable qemu-traditional



Juergen Gross writes ("[PATCH] osstest: explicitly set either enable or disable 
qemu-traditional"):
> Instead of setting "--enable-qemu-traditional" or not, switch to
> setting "--enable-qemu-traditional" or "--disable-qemu-traditional".
> 
> This avoids a latent bug in the disable case, as the availability
> of the option is tested via grep, which will otherwise grep for
> nothing.
...
> +    my $qemutrad_opt = $r{arch} =~ m/amd64|i386/ ? 
> "--enable-qemu-traditional" : "--disable-qemu-traditional";

The effect of this is that we will now explicitly disable qemu trad on
non-x86 architectures (assuming configure supports it).  I think that
is fine.

Reviewed-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>

For the avoidance of any doubt,

Release-Acked-by: Ian Jackson <iwj@xxxxxxxxxxxxxx>

too.  So I will push this now.

Thanks,
Ian.



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.