[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86/hpet: setup HPET even when disabled due to stopping in deep C states
- To: Roger Pau Monne <roger.pau@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Wed, 27 Oct 2021 01:08:43 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dY7p4zfKEf51a7lsmM858uXPFZIZDnvj98syNj/Jcnc=; b=K8lIIXNyUD3W/QxkEItOA9Zu90vRJGaBnqPkGOySmiDCRBKCNnZ2MTM5zmfiMqCkhm2lzCoaoE9QZC6ZlJzdXyfGuLcGsSSgqIpeOkPo9W71pX//Fd/ImePHtXRuQMocticuuea7QIcRtru6ZBZsbyMW+SBdNCzyho30MMHlA6jAgppjD6ikt333p57Tzjl/7bvk1yV1E02ItCahBW0iDkjIGTFDbLKCYlUAaPmX7jwF3C0i1bZNP1Oq3pFbUeFLDrednSDx6nADnkzZ3yEDHvfn7rxE/XNZQULcvtzwNYzfivGvx9mkSbJzeJXK6g6w+jbpFLjjIIO/SjJQfa1j3Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hwPrpBMdaAbQHo787oICEd3Vt5bcr5lg+zySf675MzSfpmAgZOj7O+vXlHbsW+7AGu9wL3ikslXsPBkVQaLacWjvcVNzG5jNs27G7GzutvRS8Y4EY9sZwthdKgC77WjHRLt0Jlwz0hvn+Bjzuc9bP4i2/mXPgV+sWePCFn8iEnHvLnR2A/9wUZmFDx7cS+c+A1cE68st4f2Qu8SQbGq3N+UNd9mvt5t5NmAnXF16wclI7LzZKcE9Q9Px26L9zoXB9MmVlh+ICaLauRsQq0mxqDCWB+E6E3yLERlfaBma+KHUYeQKV7ANiHJb60VrjMyjNUCJSQROgThzOjS/1YRcnQ==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Jan Beulich <jbeulich@xxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 27 Oct 2021 00:09:20 +0000
- Ironport-data: A9a23:ZMs88aj2xw7sgdv/9VRUtmRVX161gRcKZh0ujC45NGQN5FlHY01je htvWjiOOveMYGenL4hxYIyy/U0OvJaByNFqHgs++yk3Eysb9cadCdqndUqhZCn6wu8v7a5EA 2fyTvGacajYm1eF/k/F3oAMKRCQ7InQLlbGILes1htZGEk0F0/NtTo5w7Rg29Yy34Dla++wk YiaT/P3aQfNNwFcagr424rbwP+4lK2v0N+wlgVWicFj5DcypVFMZH4sDfjZw0/DaptVBoaHq 9Prl9lVyI97EyAFUbtJmp6jGqEDryW70QKm0hK6UID66vROS7BbPg/W+5PwZG8O4whlkeydx /1Wib6OS0AsJJTnxvYFXAYHCxthL4NvreqvzXiX6aR/zmXDenrohf5vEFs3LcsT/eMf7WNmr KJCbmpXN1ba2rzwkOnTpupE36zPKOHCOo8Ft24m5jbeFfs8GrjIQrnQ5M8e1zA17ixLNauAP pdJN2swBPjGSxweEAsnA4wGoMmTlEHuTGxysX62opNitgA/yyQuieOwYbI5YOeiVchT20qVu G/C12D4GQ0BcsySzyKf9XChjfOJmjn0MKoQHrCl8v9hgHWI23ceThYRUDOTvv2RmkO4HdVFJ CQpFjEG9PZoshbxF5+kAkP+8CXsUgMgt8R4CNEY1gPKz7DtyFiLHmcbESZ7d84InZpjLdA17 WOhk9TsDD1plbSaT3OB67uZxQ+P1TgpwXwqPnBcE1NUizX3iMRq1EiXF4c8eEKgpoStQWmY/ tyckMQpa1z/Z+Yw3KKn4UuPvTuoopXYJuLezlSKBjz7hu+ViYjMWmBJ1bQ5xaofRGp6ZgPY1 JThpyR4xLpWZX1qvHfUKNjh5Jnzu5643MT02DaD5aUJ+TW34GKEdotN+jx4L0oBGp9aImKzP xSD41sIvMI70J6WgUlfOdrZ5yMClvGIKDgYfqqMMoomjmZZLVfvEN5Sib64gDm2zRlEfVAXM paHa8e8ZUv2+ow8pAdas9w1iOdxrghnnDu7bcmik3yPjOrPDFbIGOxtGAbfMYgEAFas/Vy9H yB3bJDRlX2ykYTWP0HqzGLkBQpVciFrVMqv8p0/myzqClMOJVzNwsT5mNsJU4dkg75UhqHP+ HS8UVVf013xmTvMLgDiV5ypQO+HsU9XoS1pMCoyE0yv3nR/M4+j4L1GL8k8fKU99fwlxvlxF qFXd8KFC/VJazLG5zVCMsWt8N08LEym1VCUIi6oQDkjZJo8FQbHzcDpI1n0/y4UAyvp6cZn+ ++81hnWSIYoThh5CJqEc+qmyl685CBPmO97U0bSDMNUfUHgrNpjJyDr16dlKMAQMxTTgDCd0 l/OUxsfoODMpa4z8cXI2v/Y/9v4TbMmExMDTWfB7LuwOS3LxUaZwNdNALSSYDTQdGLo46H+N +9b+O7xba8cl1FQvosiT7sylfAi58HirqNxxxh/GCmZdEyiD75tLyXU3cRLsaERlLZVtRHvB xCK89hef76IJNnkABgaIw98NraP0vQdmz/z6/UpIRqluH8rreTfCUgCbQORjCF9LaduNNJ3y Ogsj8ca9gijh0d4Kd2BlC1VqzyBI3Fov3/LbX3G7FsHUjYW92w=
- Ironport-hdrordr: A9a23:NZ/Ze629ZZgMbN+vmSSCbAqjBSByeYIsimQD101hICG9Lfb3qy n+ppsmPEHP5Ar5OEtBpTiBUJPwJk80hqQFn7X5Wo3SIzUO2VHYUL2KiLGC/9SOIVyEygcw79 YYT0E6MqyMMbEYt7eI3ODbKadZ/DDvysnB7o2yvhQdL3AZV0gj1XYeNu/yKDwHeOAsP+tdKH Pz3Lsim9PtQwVsUiztbUN1LtQr6ue72K7OUFojPVoK+QOOhTSn5PrTFAWZ5A4XV3dqza05+W bIvgTl7uH72svLhCP05iv21dB7idHhwtxMCIiljdUUECzljkKNaJ56U7OPkTgpqKWE6Uoskv PLvxA8Vv4DpE/5TyWQm1/AygPg2DEh5zvLzkKZu2LqpYjDSDczG6N69MlkWyqcz3BlkMB30a pN0W7cnYFQFwn8kCP04MWNfw12l2KvyEBS0tI7vjh6a88zebVRpYsQ8Ad+C5EbBh/374ghDa 1HENzc3vBLalmXBkqp/lWH+ObcG0jbIy32BnTr4qeuon9rdTFCvgolLfUk7zU9HMlXcegD2w zGWp4Y3I2mAPVmNJ6VP91xNfdfPFa9CC4kAFjiVGgPK5t3TE4li6SHqondt9vaNaDh8vMJ6e L8uRVjxDYPR34=
- Ironport-sdr: SnVNSyueiUM7aVnfwZZMAFK8QXnodC/JiJHX9xq8f75iUHcHXEmcrH7EfknvVrG1RKGTynBTdq laTdC42MzWW85G65tdrqMlr0n+mQ999GwikkyinvLk3TXtBL1lTI0J+gsQdenGpWNaqr6cJHnU ZwNwn9GhpKmOrlHpv4iJKK7B2kPCBDvoFrmHfRs01RNF2C9KPYT+MsM0QQtosLa9uxjdLYNQVZ E8gpLwoKwzmp6f0caojG/7f0+4vQZxVYpahfroB0TakIrWSTRJ5BMMr0tZVmlSRa8O6SyPI8Oh IwV62RST8d9LOFXo/L7im+uF
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26/10/2021 16:12, Roger Pau Monne wrote:
> Always allow the HPET to be setup, but don't report a frequency back
> to the platform time source probe in order to avoid it from being
> selected as a valid timer if it's not usable.
>
> Doing the setup even when not intended to be used as a platform timer
> is required so that is can be used in legacy replacement mode in order
> to assert the IO-APIC is capable of receiving interrupts.
>
> Fixes: c12731493a ('x86/hpet: Use another crystalball to evaluate HPET
> usability')
> Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Yup - does fix the regression.
Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Tested-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
