[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 03/11] vpci/header: Move register assignments from init_bars

  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Date: Wed, 27 Oct 2021 10:17:02 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=epam.com; dmarc=pass action=none header.from=epam.com; dkim=pass header.d=epam.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OQK98qWp/1lENa6X6N98dzHtyEK5xhe6l9LbTzVHU7g=; b=CWU1EEMl8jMYfal115hxCFBKNB7ue9uiBKw5OdejKNZAkUk1TFxprXVXGUAS1rFTlHxDKYZAOxkH1ew/1ywWTTnZfACQ3R8/i8LZAcP/Fk6585bJGzq/jQWO3CYPeiMJf9wxei5hquSeGgRp14zFT4PHXyqBOymYrZjCfsjQfxgTrmPgBhyK5T/1bjRJP8HPdt+BDt7Y74c6CPD2VNU1PcvSlWxXYUj/HhxF3yE6OVnIAioybEgqr2JH0cYoyqH+7HWXL0PavLKOwKLn6CAdfaqV06N9QzBiqHWq5mXuy6pLu3A2+vFkwvtKdWSbhvRVEX4i7EC7otdZmm7nnX5xVA==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nJ/AfkCy52lvOvbu4Gc1tw/8ZRW3HHo1tGwHgx96lFRRzYNflpPO+KOgTOvb4i11TflLqKCDkYVNL6/PAq54K2Byr9koCY31+9cEQv5j7dmTjKZIYZUYYPQkUQJ76454ZchiYwbBpbn9DaxPVW2g9/gdDH53aE2t+Hso2MmM82cLjuVdI24S5rq5V7wuclhNONe0NyM0sQY4pk1V45uU50dnTvVZwW7cc0D8HBt+3g92bUSUqER5KC9EUMoZWg2tK/jGwsrQ//6wQJ1xV5547ClFdSIonuwemMWmI3yH4kJYG+wb4K/emyYPdTA1hZe7kvDzRrV1RlUXWUyFKz0e8A==
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "jbeulich@xxxxxxxx" <jbeulich@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
  • Delivery-date: Wed, 27 Oct 2021 10:17:32 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXtdAhPfrDnvz+/U+T4IKIC1fCcavRBz+AgBXEsIA=
  • Thread-topic: [PATCH v3 03/11] vpci/header: Move register assignments from init_bars

Hi, Roger!

On 13.10.21 16:51, Roger Pau Monné wrote:
> On Thu, Sep 30, 2021 at 10:52:15AM +0300, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>> This is in preparation for dynamic assignment of the vPCI register
>> handlers depending on the domain: hwdom or guest.
>> The need for this step is that it is easier to have all related functionality
>> put at one place. When the subsequent patches add decisions on which
>> handlers to install, e.g. hwdom or guest handlers, then this is easily
>> achievable.
> Won't it be possible to select the handlers to install in init_bars
> itself?
It is possible
> Splitting it like that means you need to iterate over the numbers of
> BARs twice (one in add_bar_handlers and one in init_bars), which makes
> it more likely to introduce errors or divergences.
> Decoupling the filling of vpci_bar data with setting the handlers
> seems slightly confusing.
Ok, I won't introduce add_bar_handlers, thus rendering this patch useless.
I'll drop it and re-work the upcoming patches with this respect

Thank you,



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.