Re: [PATCH] PCI/MSI: Move non-mask check back into low level accessors

[David Woodhouse <dwmw2@xxxxxxxxxxxxx>]

On 27 October 2021 10:50:15 BST, Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote:
>The recent rework of PCI/MSI[X] masking moved the non-mask checks from the
>low level accessors into the higher level mask/unmask functions.
>
>This missed the fact that these accessors can be invoked from other places
>as well. The missing checks break XEN-PV which sets pci_msi_ignore_mask and
>also violates the virtual MSIX and the msi_attrib.maskbit protections.

Not just PV. It's Xen HVM guests too.

I'll also give it a spin on both Xen and not-Xen. Thanks.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.