[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH][4.16] x86/x2APIC: defer probe until after IOMMU ACPI table parsing [and 1 more messages]


  • To: Ian Jackson <iwj@xxxxxxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Thu, 4 Nov 2021 16:09:23 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QnZo+JwINu+yj1b7l3ZCxTtCOlVokXmizl2oT8gQ4ow=; b=nmXIx+wlo6b199kd20rkmWgZhOzpeRRNF2koqUnaO9M3tshGerWdGgH4wOOds9aJoHuL9NbO5ddnIsAN/57opmWoJ9vu66AibFBlgHTvTpSx2BoOLfCDyI4ZpJv4UtRDgnhlS2/PnUg70lpfgUUqtKHgyg1BoocqC/4OM+ADVc86j9rfbY8P3BVvXo9ha51LLY/Nhbb48KkOFoN8Iw1j5H/SVDEwGFUJqFCZRF98GNW6g+GJwOkNSYbK5q6+DbqyHH6vrmfjLbQPJjTGUmDYFLgabQgJ8qudafdEyQL5H3/ujxfyzqUgFaMyqi6rzxsAqcI2UhfjkUyAw5jwmLzSgQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WchwRT3yTzdIaLNb4Fkq6UhQ0XEaUxtNINjEOfTFr9ENVfVSAqDi9B9imSaBdf1PjM3QZT1yWQHD0jvFf7q6doE5LRH1Jbg/UIU7ugyBrkjKME4CpetVgH4i6qib8EoQ/bXLddX/yGcXFMSmQcBqIWNLuq9EkXL1G2LVSUC37PZjcWJabAdRM76bhLk6bG0SQmrYTJNwmg+YPogLEtz8+soe9ecbI10sV8ZMJROY8jCWkSCLl6uYvgGuTE9cB0QpnLyZOXcnmf11JQ/PWkVdQfXr4AhPDbkk2jw71r5bmby6jp+IWRBycd7z9FQwtACsLmwEyDzZpAMT7aRsGBJl9A==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • Delivery-date: Thu, 04 Nov 2021 15:10:00 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 04.11.2021 15:59, Ian Jackson wrote:
> Jan Beulich writes ("[PATCH][4.16] x86/x2APIC: defer probe until after IOMMU 
> ACPI table parsing"):
>> While commit XXXXXXXXXXXX ("x86/IOMMU: mark IOMMU / intremap not in use
>> when ACPI tables are missing") deals with apic_x2apic_probe() as called
>> from x2apic_bsp_setup(), the check_x2apic_preenabled() path is similarly
>> affected: The call needs to occur after acpi_boot_init() (which is what
>> calls acpi_iommu_init()), such that iommu_intremap getting disabled
>> there can be properly taken into account by apic_x2apic_probe().
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> ---
>> Based on code inspection only - I have no affected system and hence no
>> way to actually test the case.
> 
> Do we have any tests for this ?

If you mean in osstest, then I'm unaware of any, but I also don't have
a clear view on how much x2APIC-capable hardware we have, and whether
among those there are any where the firmware pre-enables x2APIC.

>  I see it's tagged for 4.16 (and I'm
> favourably inclined) but I'm not sure I follow the implications.

The main aspect here is: This is the other side of the medal as to the
referenced earlier change (which I did commit an hour or so ago).

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.