[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2.1 1/6][4.16?] x86/x2APIC: defer probe until after IOMMU ACPI table parsing
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Date: Mon, 8 Nov 2021 12:54:36 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gvwTWBO78gYjePkOz6Qet8Iqr9ShlnVZ5B/L6m9IocA=; b=nCazKOwCBwkZaZrsCEEIKDG/Ye3mwZTvPeFDBk2p4HYnYau+Qnpp2FPzWyBmGvi7nRHRxmrNomvDKIXC+jzhQrKf0yv5H9YcwfNiq2dFXq1cBC5BtGCoeG4lli9z9bZqK1Qs5hivD0+WBWMoJ2Z0pdnzMjFLZfY995iQHpf6g7/mbNvMXWlKmRXbrtN1hptes5NX9NfT4u0ieVMJAyeHOBQmr93uP5ppBcovll12x3n/OjStNodxcVl7/s6o0GPrfJYCPTaD6T0DefL0Zmi0yqD1Bx2OUthG8K9o/9OEpzpDlFKI/R8umKZ9QXJw5AF8KJYM+Cl/4pMC4uBojdrZ9w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=glUjEAOe+SEZPYlmjZIke40fIZHeCiku0GuQA8lu27wvI/ll42Kp/chBJINKCBO1Cw9c3rQgKyGP15lrSgE0/dt4RKK2xZOeb24ch8+Nn2e65nQC4l2dFpyqjEjmAArPhXVZhGsIk+Cyyv/4+tApUjfK0xItvRzWS5udU+wNm4x8ROHhUPuW9MFqNDwRBlob9XP+v02i1PEFTiNCDD39ekSYt96RK8gqtIL4Z2OL3pUxPP6x2dUoayKTLiu+fFOn4KNWPI0pgFt2GC3eTQ+r4XlaRUQNkaqHmil6sbCvuGeD91R43JFStPufB+4LxXc/KkugdSMQDEUflHSwHVOu2A==
- Authentication-results: esa5.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
- Delivery-date: Mon, 08 Nov 2021 11:55:06 +0000
- Ironport-data: A9a23:x8KGCq6kjkNXPJCEzyPRWwxRtM3AchMFZxGqfqrLsTDasY5as4F+v jAbCGyOPayDNDejet9zbYS29UlS7MPRy9JiSQA9/3hkHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuV3zyIQUBUjclkfJKlYAL/En03FVAMpBsJ00o5wrdg2t4w2LBVPivW0 T/Mi5yHULOa82Yc3lI8s8pvfzs24ZweEBtB1rAPTagjUG32zhH5P7pGTU2FFFPqQ5E8IwKPb 72rIIdVXI/u10xF5tuNyt4Xe6CRK1LYFVDmZnF+A8BOjvXez8CbP2lS2Pc0MC9qZzu1c99Z0 u9OpMKPGDUTALTjgd46fzd1HiRHMvgTkFPHCSDXXc27ykTHdz3nwul0DVFwNoodkgp1KTgQr 7pCcmlLN03dwbLtqF64YrAEasALNs7kMZlZonh95TrYEewnUdbIRKCiCdpwgWlg3J8fQKm2i 8wxeD4/VDXwPSB1Z3hPCY85nMqipH77SmgNwL6SjfVuuDWCpOBr65DsL9j9atGMXd9SnEuTu iTB5WuRKgkTKdi32TeDtHW2iYfngifTSI8UUrqi+ZZCglee22gSAx0+TkagrL+yjUvWc8JSL QkY9zQjqYA29Ve3VZ/tUhugunmGsxUAHd1KHIUHBBqlk/SOpVzDXy5dE2AHOIdOWNIKqSICz GWKjo3WVA5VjqS6UEi62pm5oDaLNn1ARYMdXhMsQQwA6tjlhYg8iBPTU9pueJKIYs3J9SLYm G7T8nVn71kHpYtSjvjgowib6965jsGRFlZd2+nBYo6yAuqVjqaBbpfg11XU5O0owG2xHgjY5 yhsdyRzAYkz4XCxeM6lHb1l8FKBva/t3NjgbblHRchJythV0yT/Fb28GRknTKuTDu4KeCXyf GjYsh5L6ZlYMROCNPEsPdnoUp12kfi+SbwJs8w4ifIUM/BMmPKvpnkyNSZ8IUi0yCDAbp3Ty b/EKJ3xXB72+IxszSasRvd17FPY7ntW+I8nfriil07P+ePHPBa9EO5ZWHPTPrFRxP7V+239r ocAX/ZmPj0CCYUSlAGMqtVNRb3LRFBmba3LRzt/LLfbc1U3RDF4YxITqJt4E7FYc21uvr6g1 lm2W1NCyUq5gnvCKA6QbWtkZq+pVpF6xU/X9wR3Vbpx83R8M4up8okFcJ47Iesu+OB5lKYmR PgZYcSQRP9IT22fqTgaaJD8qq1kdQiq2l3Sb3b0PmBncs4yXRHN9//lYhDrqHsEAB2ouJZsu LanzA7aH8YOHlwwEMbMZfuz5FqtpnxByvlqVk7FL4ALKkXh+YRnMQLrifozL51eIBnP3GLCh Q2XHQ0Zta/GpIpsqIvFgqWNroGIFepiHxUFQzmHvOjubSSDpzit245NVuqMbAvxbmKs9fXwf /hRwtH9LOYDwARAvb1jHus51qk5/dbu+eNXl1w2AHXRYl23Ibp8OX3aj9JXv6hAy7IF6wu7X kWDpotTNbmTYZ63FVcQIEwub/iZ1OFSkT7XtKxnLEL/7S5x3byGTUQNYEXc1H0DdON4YNE/3 OMsmM8K8Aju2BMlP+GPgj1Q62nRfGcLVL8qt81CDYLm4ubxJoquvXAI5vfK3ayy
- Ironport-hdrordr: A9a23:EJRPSam9YsGPlMjiLePg35LMq2rpDfO2imdD5ihNYBxZY6Wkfp +V88jzhCWZtN9OYhwdcLC7WZVpQRvnhPlICK0qTM2ftW7dyRaVxeBZnPDfKljbdREWmdQtt5 uIH5IObeEYSGIK8foSgzPIYurIouP3iZxA7N22pxwGLXAIGtFdBkVCe36m+yVNNXd77PECZf yhD6R81l6dkSN9VLXFOpBJZZmIm/T70LbdJTIWDR8u7weDyRuu9b7BChCdmjMTSSlGz7sO+X XM11WR3NTuj9iLjjvnk0PD5ZVfn9XsjvNFGcy3k8AQbhHhkByhaohNU6CL+Bo1vOaswlA3l8 SkmWZsA+1Dr1fqOk2lqxrk3AftlB4o9n/Z0FedxUDupMToLQhKQvZptMZ8SF/0+kAgtNZz3O ZgxGSCradaChvGgWDU+8XIfwsCrDv0nVMS1cooy1BPW4oXb7Fc6aYF+llOLZsGFCXmrKg6De hVCt3G7vo+SyLVU5nghBgt/DWQZAVwIv/fKXJy//B9kgIm00yR9nFohPD2xRw7hdYAo5ot3Z WzDk0nrsAIciYsV9MOOA42e7rBNoX8e2O+DIusGyWTKEgmAQOEl3el2sR/2AmVEKZ4uKfa3q 6xFm9liQ==
- Ironport-sdr: WFb/6hKgfGKpTOSN7ArkPDRUqdK5Z1o/pR0lgBXnKrDEGhKq1JLaQyCPo2v0j5gS7xcybbtOEU GUL9+ME1qUziv2gaFQnctJneUqGQ0ffhfxMBk8ls1bHu8yzJO8jo/Euntvt1Fu66yH6jcMyjtQ XBImXGVPnVX5sHeM8x6whedCrIMhvW1ZOXLGNPrSWA7mwcP+RG/2sHy38kpwjJv+QaC9Nnxr2w TmoZWoTEsbZRpIM+eVlnKOBpPfP6+Crj9LBlIpL0hnpTKIsUyiaouX7on9dVVRD5VC2+xGH91b VVhZnCCtOAej6l9fS9C/6XAN
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On Mon, Nov 08, 2021 at 12:40:59PM +0100, Jan Beulich wrote:
> While commit 46c4061cd2bf ("x86/IOMMU: mark IOMMU / intremap not in use
> when ACPI tables are missing") deals with apic_x2apic_probe() as called
> from x2apic_bsp_setup(), the check_x2apic_preenabled() path is similarly
> affected: The call needs to occur after acpi_iommu_init(), such that
> iommu_intremap getting disabled there can be properly taken into account
> by apic_x2apic_probe().
>
> Note that, for the time being (further cleanup patches following),
> reversing the order of the calls to generic_apic_probe() and
> acpi_boot_init() is not an option:
> - acpi_process_madt() calls clustered_apic_check() and hence relies on
> genapic to have got filled before,
> - generic_bigsmp_probe() (called from acpi_process_madt()) needs to
> occur after generic_apic_probe(),
> - acpi_parse_madt() (called from acpi_process_madt()) calls
> acpi_madt_oem_check(), which wants to be after generic_apic_probe().
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks, Roger.
|
