[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2.1 1/6][4.16?] x86/x2APIC: defer probe until after IOMMU ACPI table parsing


  • To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 15 Nov 2021 13:06:31 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d+GTYTFUICm269A3Q4jbFl1JERSp+SKx9aeCBMsHZpQ=; b=cc60UVuIgpJXAaZaxbuArijrOXXwlaUvQckOcNA6OitRccF3+M+je6/Xm6DrI9iVU92s/FLeeRPndcYJWgit9jwPsfufjReA2+ZzDHR3SowUHYQ2Pxf80Pk8sgsYNgzTu0p2+1tZn1f/wWPYr9g8unyJHDpIi7hSYlLH5GTu0Yctt90HGG89x3ObeVCpUYMZx4O9KdLwJ0PfP8Ceow+kDUPqCbkdwr18yq/AHGOO8sGJml6QAHrE0l0ZVg1Xvsp+mSTUBaacaYH3bC+1X8TFPEvAN3jbLwcytktApKZa8nk7WVbx6ZmjnZQw9NFCLUoBTk7b7LcN9fmE3czzsMXEiQ==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BbwODlRmvmnNS9onEFgNgdwdikvibEnLtSVrvmE5bJ8hDXIM8U0hgw+NqEj/gVKQfCAUc7OJKoqsEhFCI7/7j2BGuMhYjKgYqZOQlN/zEogtpFukyaU/xgfgmA9Glv4jdVFNZb5X0FTbKOuLSxLxJrUZsR0yfioWRJQfHyOuARR7Seo09I0T+L/x/NcRoHxOdDSNcJM71GtqZosbsCuVZEaj/InH/Gg8fAINRJv9UiL/XqrX78DGgEZYJwoHbz1tWTGKGovEhnZBKqx3hFHqqcjKnoTcn1wS3eekeV57XAhnOVp+dt7wqj8gXbZWtqGwk936ZqVg8rFXQryae+jdMQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Paul Durrant <paul@xxxxxxx>
  • Delivery-date: Mon, 15 Nov 2021 12:06:38 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 08.11.2021 12:54, Roger Pau Monné wrote:
> On Mon, Nov 08, 2021 at 12:40:59PM +0100, Jan Beulich wrote:
>> While commit 46c4061cd2bf ("x86/IOMMU: mark IOMMU / intremap not in use
>> when ACPI tables are missing") deals with apic_x2apic_probe() as called
>> from x2apic_bsp_setup(), the check_x2apic_preenabled() path is similarly
>> affected: The call needs to occur after acpi_iommu_init(), such that
>> iommu_intremap getting disabled there can be properly taken into account
>> by apic_x2apic_probe().
>>
>> Note that, for the time being (further cleanup patches following),
>> reversing the order of the calls to generic_apic_probe() and
>> acpi_boot_init() is not an option:
>> - acpi_process_madt() calls clustered_apic_check() and hence relies on
>>   genapic to have got filled before,
>> - generic_bigsmp_probe() (called from acpi_process_madt()) needs to
>>   occur after generic_apic_probe(),
>> - acpi_parse_madt() (called from acpi_process_madt()) calls
>>   acpi_madt_oem_check(), which wants to be after generic_apic_probe().
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Reviewed-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Thanks, but testing again revealed a problem, this time on AMD. The
dependencies are yet more complicated, so it'll need to be a mix of
v1 and v2: acpi_iommu_init() needs to be split out, but
generic_apic_probe() also needs to move. That's because
_pci_hide_device() relies on dom_xen to have got set up before.
Expect v2.2 after I have actually tested the outlined change.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.