Re: [PATCH v3 00/10] direct-map memory map

[Julien Grall <julien@xxxxxxx>]

Hi Jan,

On 16/11/2021 07:49, Jan Beulich wrote:
> On 16.11.2021 07:31, Penny Zheng wrote:
> > v3 changes:
> > - move flag XEN_DOMCTL_CDF_INTERNAL_directmap back to xen/include/xen/domain.h,
> > to let it be only available for domain created by XEN.
> > - name it with extra "INTERNAL" and add comments to warn developers not
> > to accidently use its bitfield when introducing new XEN_DOMCTL_CDF_xxx flag.
> FTR I continue to object to the hijacking of a public interface bit for
> this purpose. Not to the degree of nak-ing the change, but still.
I remember this discussion in v1 and I am a bit confused why this was 
re-introduced. Looking at the thread, I think you and I were happy with 
the following approach:
  1) Switch the last parameter of domain_create() (i.e. bool is_priv) 
to flags.
  2) Define a bit in the parameter to indicate whether the domain will 
be direct-mapped.
Cheers,

--
Julien Grall