Re: [XEN][RFC PATCH v4 1/1] Update libfdt to v1.6.1

[Julien Grall <julien@xxxxxxx>]

Hi Stefano,

On 16/11/2021 03:15, Stefano Stabellini wrote:
> On Mon, 15 Nov 2021, Julien Grall wrote:
> > On 12/11/2021 22:01, Stefano Stabellini wrote:
> > > On Fri, 12 Nov 2021, Luca Fancellu wrote:
> > > > > On 12 Nov 2021, at 07:27, Vikram Garhwal <fnu.vikram@xxxxxxxxxx> wrote:
> > > > >
> > > > > Update libfdt to v1.6.1 of libfdt taken from
> > > > > git://github.com/dgibson/dtc.
> > > > > This update is done to support device tree overlays.
> > > > >
> > > > > A few minor changes are done to make it compatible with Xen:
> > > > >      fdt_overlay.c: overlay_fixup_phandle()
> > > > >
> > > > >          Replace strtoul() with simple_strtoul() as strtoul() is not
> > > > > available in
> > > > >          Xen lib and included lib.h.
> > > > >
> > > > >          Change char *endptr to const char *endptr. This change is
> > > > > required for
> > > > >          using simple_strtoul().
> > > > >
> > > > >      libfdt_env.h:
> > > > >          Remaining Xen changes to libfdt_env.h carried over from existing
> > > > >          libfdt (v1.4.0)
> > > > Reviewed-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> > > >
> > > > I’ve also tested it on FVP and on a Juno board, starting few guests and it
> > > > worked.
> > > >
> > > > Tested-by: Luca Fancellu <luca.fancellu@xxxxxxx>
> > > Thanks Luca! The patch also passes the gitlab-ci tests and looks OK to
> > > me. I'll let Julien ack it as he was the one with a couple of comments
> > > before.
> > The next version addressed my comments. So:
> >
> > Reviewed-by: Julien Grall <jgrall@xxxxxxxxxx>
> >
> > I have also queued the patch in a temporary branch for-next/4.17:
> >
> > https://xenbits.xen.org/gitweb/?p=people/julieng/xen-unstable.git;a=shortlog;h=refs/heads/for-next/4.17
> >
> > The patch will land in staging when the tree re-opens.
> Hey Julien,
>
> Thanks for that!
>
> Do you think it would make sense to keep "for-next/4.17" under
> xen-integration [1] so that we can easily trigger gitlab-ci runs on it?
It would be good to have gitlab-ci running on the branch. However...

> I cannot setup an automatic mirror of your branch on xen-integration
> because xen-integration is already mirroring upstream xen.git. For now,
> I have just manually pushed:
> https://gitlab.com/xen-project/fusa/xen-integration/-/tree/for-next/4.17
>
> Which triggered (all green):
> https://gitlab.com/xen-project/fusa/xen-integration/-/pipelines/409417946
>
> FYI you should have full rights to push and make edits on
> xen-integration.
... AFAICT the tree can be edited by non-committers as well. I don't 
expect anyone in the list to mess up with the branch, but part of me 
would prefer if only you and I can modify it.
That said, I can push manually to xen-integration to trigger the CI 
everytime we need to update it.
Cheers,

--
Julien Grall