[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 06/11] vpci/header: handle p2m range sets per BAR
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>, Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 19 Nov 2021 14:57:52 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mIelfDHgW9Bl6uL3rurtp6p0J7AcKWD1v7olwfE/yn8=; b=KRrYRCPLMMdtRvxYpRwQXg23ADJJZ/CblxfA2a0wHPuL/ICkvEqwXrBX0YmkXJDK70C8wPEYVEYGld3INkD/LdoYyRxl56LMIFqQwuooaS3zPNloXOxTSmiIklWRN/7CPp9FPj0cUQM8NpNKdAcyIP7S8GW50CDXcBKgqmVFajmBSSPjDrItfW28pWb8Xzv6IAzS3Hmx7Xjvsul/fRjs5tN5yHZa7+6TlwlYFvMIiBq1hM1Q9CjJ5Zdoi+ZSzS+3hWpOzG20ERH9zvcBjKgckB2lC6UE5wcWOIBaheGdAzVvCI4cTx2hg6DFV+B2g5EVBwABnk7Y76GGa2ao+leAYg==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ldtn4LlYmQdOdw4gkKp2953yfsfJsyRtfyhqmOq80LsCWzkLGJYtK4sefjIfCM4Xfu3fun0e9NyNY8r3lBtMIcpfYnmeoexi24sD7ABQDvvqUWKaNaFD6WEkksiv2dOFDKb5LmPgEv/VQYvsegif1AecwBJj1zwgZASRnyZuTBipyWojj7brSo4rNvZlnySr9MHnZX4QPCvY6EpHSGzpNwKXTF33cJayGHUhdC3ycdOmUpKjeJ64oYLef90kmqjAMC2lVMLOnheHy1v7ZFAX2/J98Fgw80H3YcpoJv1hA4fQr9phNytEmNGIUy8ZN7C3q0tMuFVckYQMP+odfsdPkw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "roger.pau@xxxxxxxxxx" <roger.pau@xxxxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 19 Nov 2021 13:58:10 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 19.11.2021 14:41, Oleksandr Andrushchenko wrote:
>
>
> On 19.11.21 15:16, Jan Beulich wrote:
>> On 05.11.2021 07:56, Oleksandr Andrushchenko wrote:
>>> @@ -95,10 +102,25 @@ int vpci_add_handlers(struct pci_dev *pdev)
>>> INIT_LIST_HEAD(&pdev->vpci->handlers);
>>> spin_lock_init(&pdev->vpci->lock);
>>>
>>> + header = &pdev->vpci->header;
>>> + for ( i = 0; i < ARRAY_SIZE(header->bars); i++ )
>>> + {
>>> + struct vpci_bar *bar = &header->bars[i];
>>> +
>>> + bar->mem = rangeset_new(NULL, NULL, 0);
>> I don't recall why an anonymous range set was chosen back at the time
>> when vPCI was first implemented, but I think this needs to be changed
>> now that DomU-s get supported. Whether you do so right here or in a
>> prereq patch is secondary to me. It may be desirable to exclude them
>> from rangeset_domain_printk() (which would likely require a new
>> RANGESETF_* flag), but I think such resources should be associated
>> with their domains.
> What would be the proper name for such a range set then?
> "vpci_bar"?
E.g. bb:dd.f:BARn
Jan
|
