[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 01/14] rangeset: add RANGESETF_no_print flag
- To: Oleksandr Andrushchenko <andr2000@xxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Thu, 25 Nov 2021 12:06:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lWuCeIqEXoG6zsGWy0nbE/i9plowKB5NsSYDTZwCQ2w=; b=ed/WSjYVfMGi0nbtSPaQcdh/Bk2jkcZ6blcfjw//KcjygfVgaz2JlAH6iVXRLnrx2Rz/i1hmyRW4ttLCaTiYGa5FQ8e6PtPb5thNdi2WzgDSusWfwGKcHQORORsowS49+kCE+1O4K8y0wQ1MI/G3GgJabQNuSuyxCfott2rRMrZqZSBQk0Uy7r//kzy3pb3SxqR6Hwx8kuGgWVWWTVSFleKo6Qrk+OzyvuRsF4HhmceIkMbt+GZkrC6c/9ZrR8LATm+Z8XTqIvapnL5EK1FJQou1vVqiedUHkA6Ys4Ni+5F6mbb07878ynQPXziQq4ef46ujqQ5vkeDfBLNW8wFOeA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LuTORUmHMfAr9kOgAdBKd3lr7QPMIVtdIwtyAp8YdXEAxvv8g5Da2SZ1BgbYIev6ijuvuGEHnCkqU088e5GL/kTy3D6sOQxIX8VHcge+E+OIHiAuyzZmg6sUnOwq0zHgyOuVTmmeGfd6aloLkptQEXOWVdpa4sJkJmTLiVGpM4k6+Bpe8RBxyNf14nI9Au8VDQAAuaBGOugoLL7BA3bB4V75lfs8Ig2Bvo/WPpC+8GzUNdsprqauqooUwcI5jT5JgEo1Fn/0qpYhOWXxyGrA1kD6NymZFJc7N24rco8MqQVdAA0ND7lbuNEfCN5ZGMBWjuhuZIQaLzZz9t3gq0n2kA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: julien@xxxxxxx, sstabellini@xxxxxxxxxx, oleksandr_tyshchenko@xxxxxxxx, volodymyr_babchuk@xxxxxxxx, Artem_Mygaiev@xxxxxxxx, roger.pau@xxxxxxxxxx, andrew.cooper3@xxxxxxxxxx, george.dunlap@xxxxxxxxxx, paul@xxxxxxx, bertrand.marquis@xxxxxxx, rahul.singh@xxxxxxx, Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx
- Delivery-date: Thu, 25 Nov 2021 11:07:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.11.2021 12:02, Oleksandr Andrushchenko wrote:
> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>
> There are range sets which should not be printed, so introduce a flag
> which allows marking those as such. Implement relevant logic to skip
> such entries while printing.
>
> While at it also simplify the definition of the flags by directly
> defining those without helpers.
>
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
albeit with a remark:
> --- a/xen/include/xen/rangeset.h
> +++ b/xen/include/xen/rangeset.h
> @@ -48,9 +48,10 @@ void rangeset_limit(
> struct rangeset *r, unsigned int limit);
>
> /* Flags for passing to rangeset_new(). */
> - /* Pretty-print range limits in hexadecimal. */
> -#define _RANGESETF_prettyprint_hex 0
> -#define RANGESETF_prettyprint_hex (1U << _RANGESETF_prettyprint_hex)
> +/* Pretty-print range limits in hexadecimal. */
I would guess this comment was intentionally indented by a blank,
to visually separate it from the comment covering all flags. I'd
prefer if that was kept and if the new comment you add followed
suit.
Jan
|
