Re: [PATCH v5 01/14] rangeset: add RANGESETF_no_print flag

[Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>]

On 25.11.21 13:06, Jan Beulich wrote:
> On 25.11.2021 12:02, Oleksandr Andrushchenko wrote:
>> From: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
>>
>> There are range sets which should not be printed, so introduce a flag
>> which allows marking those as such. Implement relevant logic to skip
>> such entries while printing.
>>
>> While at it also simplify the definition of the flags by directly
>> defining those without helpers.
>>
>> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
>> Signed-off-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@xxxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> albeit with a remark:
>
>> --- a/xen/include/xen/rangeset.h
>> +++ b/xen/include/xen/rangeset.h
>> @@ -48,9 +48,10 @@ void rangeset_limit(
>>       struct rangeset *r, unsigned int limit);
>>   
>>   /* Flags for passing to rangeset_new(). */
>> - /* Pretty-print range limits in hexadecimal. */
>> -#define _RANGESETF_prettyprint_hex 0
>> -#define RANGESETF_prettyprint_hex  (1U << _RANGESETF_prettyprint_hex)
>> +/* Pretty-print range limits in hexadecimal. */
> I would guess this comment was intentionally indented by a blank,
> to visually separate it from the comment covering all flags. I'd
> prefer if that was kept and if the new comment you add followed
> suit.
Ah, ok, so I will add a space for the new flag's comment as well then
> Jan
>
Thank you,
Oleksandr