[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] xz: add fall-through comments to a switch statement
- To: Julien Grall <julien@xxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 26 Nov 2021 08:37:59 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jbMDIm8r/E/Dx5ukXSVlralAVqlm8TXP7b9TxtnTxo8=; b=EY7EpBZj9YEpZB39ttRYqfclFPjpMAAUnekW4Izn5+GazizRJPXiaJpN7tKxiI46ltlUFgIiJ8dlTDaQgrHaDQz0IRsOa1ude0eNXIrCD7hOcLXVJ/qx9PAWYVuL+6nNtCjq2pJoPLJEXAx6PF6/Dt9nUXhsRS+68VGxJ7uGBxev8oqhgUcdvZGe3pPZo3iDFyd+R3nQFgC8omFgx5elP012aeJIUhDns9R1ZvwPiFUOljgqaP9l9jXAWwDqEk3U2EWc99+zfX/ghjzNZ3N/FNLRD0iM6pIJHyJ7b8uPw+vOqH0qGsPRTUbsNho1y1rS+vRYmnjxYZ76jomIoTinJA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ePI1aFNFn7aWEaBCvCO+9HXO8nOHPXBdWafUzXuEnI4Bcj22X+v6wYfpUtPhG9md7m0kiIFhySUM0B4Bth76AYo9TgD+yF/MkmGJoMPqJ5zCKV50gOsSIJ03y1fntNC18kWUz+arhehJW/k5Io7FEznHtvNq9jhkI8n60UkJLusV5AkFQCKWK41PDa1BV/o8gnSveMF7tH2tZ/12dR0xgAtbkiKyC+KXNOSBivMjKxtQbou0wqfW5IpeTDUjKwYa3VxWbbb01W4arZVLnU/49VGeGQqEHAEaTQ4gV+qwuhYmvxWG5lgxJ5ZADT63J707Ip9+gBl//ytpMOgE610rAQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, George Dunlap <george.dunlap@xxxxxxxxxx>, Ian Jackson <iwj@xxxxxxxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Fri, 26 Nov 2021 07:38:26 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 25.11.2021 18:13, Julien Grall wrote:
> Hi,
>
> On 25/11/2021 17:03, Jan Beulich wrote:
>> On 25.11.2021 17:54, Julien Grall wrote:
>>> On 25/11/2021 16:49, Julien Grall wrote:
>>>> On 19/11/2021 10:21, Jan Beulich wrote:
>>>>> From: Lasse Collin <lasse.collin@xxxxxxxxxxx>
>>>>>
>>>>> It's good style. I was also told that GCC 7 is more strict and might
>>>>> give a warning when such comments are missing.
>>>>>
>>>>> Suggested-by: Andrei Borzenkov <arvidjaar@xxxxxxxxx>
>>>>> Signed-off-by: Lasse Collin <lasse.collin@xxxxxxxxxxx>
>>>
>>> Actually, any reason why there are some signed-off-by missing?
>>
>> I often keep the author's, but drop ones which clearly got there only
>> because of the path a patch has taken through trees.
>
> This might be clear for you. For me, as a reviewer, I have to do extra
> work to check whether you keeped the relevant signed-off-by.
>
>> These aren't
>> relevant imo when pulling over the change;
>
> They are technically part of the "chain of approval".
But the Linux chain of approval is precisely what is of no interest to
us. We need to approve the change ourselves; Linux having had it
approved is merely a data point.
>> I could as well take the
>> email submission as my basis, after all, where just the single S-o-b
>> would be there.
>
> That's a fair point. That said, you took the commit-as-is from linus.git
How would you be able to tell?
> so I think we ought to keep them.
I disagree. And I'd like to remain consistent with what I've been doing
in the past.
Jan
|
