[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 17/65] xen/evtchn: Annotate fnptr targets
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 29 Nov 2021 14:51:22 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WJgKJSP5DW5Bq/wc15bS7aAnbsZ1fEXXDIUZLe3CRes=; b=R+BgV3ehEk+6F+DIyKtHwM7pc7337+Ja4gSbJMUy+DNbnC4l0QswrsoLAMaGOxOcFcyb7b+BUZ1c9R/RziFdfbX8R8IS+2y137VZBdZ4+vNGC6wVLRSiWM8wdhOQi8kgKFS4IqU8mipurbQIAan2VZ9XlphQeD9gsqkx2iFfoxYZ/ZqLdA6fNrzupXtq57Hbaat78VeerKNqf9dEGr7o4sVRmln5py9+2G78+oaZAY9KTA6FRB+uWtwSapMHDuX6v+nw66KCDXK3MFvJSxxiFIZ3NRqyBlymhowuZGOSzqNxV/dvb1oA7lpTeu1WgMAyIjyTEH3iEbeHNdmxvpy+zw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LJgQiUr6RjBOqFDps03tJbDLZHSi742l42QqniWH28vEDPnkwiRtVG8LaooVl4Nc0oNuAJPTnUsZYOtkSuQItJ0rEkLWx4R+7v9Xp6ZItuyzyDe7zDG7CVEvRWYyN73vaEZvaWoMdfK9nNQWz3Vt/rF3gCSjXvE7e6qFXThVDuiFGP4qFXXOdfAl7DwhtjzU622JzeMADVfxx+LkCZaN/4/Q0Xl4N/Oxilhd633N0LJuNoEP+Trb8/r4qtNh0SMcTFwIByZeVgOtYIyTC8+XQm+LgJWyfY484THPb+CDUiam+tCmFEY2vF7jd7MUOhbw/3lk1A5k9cMy/VpNCMpumg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 29 Nov 2021 13:51:38 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.11.2021 13:33, Andrew Cooper wrote:
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -99,7 +99,8 @@ static xen_event_channel_notification_t __read_mostly
> xen_consumers[NR_XEN_CONSUMERS];
>
> /* Default notification action: wake up from wait_on_xen_event_channel(). */
> -static void default_xen_notification_fn(struct vcpu *v, unsigned int port)
> +static void cf_check default_xen_notification_fn(
> + struct vcpu *v, unsigned int port)
> {
> /* Consumer needs notification only if blocked. */
> if ( test_and_clear_bit(_VPF_blocked_in_xen, &v->pause_flags) )
Alongside this shouldn't you also annotate mem_paging_notification(),
monitor_notification(), and mem_sharing_notification() right here
(following how previous patches were organized)?
I take that you're specifically leaving out anything in Arm code, no
matter whether such annotations may gain a meaning at some point (not
that I would know of any plans).
Jan
|
