[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 19/65] xen/tasklet: Annotate fnptr targets
- To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Mon, 29 Nov 2021 14:56:30 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kl+Ii5rFayTV1u5aR7KD0BD+EsHRoQqk7iPIdSU9C80=; b=nxyOcESV+6epLBO4D324xy84bK22VrsWCK47r7JqqFKa4GXiFpB23Vy8aCM3mj4b1SoB5a7PL9zhKNpeBdZ4uuaQmHUu7/P+kiVY1amH7GUiBHi575Rz07KxGYcqZFIQYVAA3GmGeZvAGUwBdcN33UgWPCsk6bLF/hCImRrOGrIDiJQhZsw9wts0PPvrg4febzj8243ICVDzjcaGKJtg95O9/SGHi3Ckt0xZqBGVFYBmg9j3qet+KbptsZtNr2dw82eyjkESj3rcMH5fjKZlV1qF3Aqt519ZSKrd5LxWrk3PoO+oI45juhjdChs8zo0lBwNpSDwgSyrJliTXjmw2lA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fAKzI0/fObkOAT+34X/+oM7YXUJVuhhHrSRInI8h0IOtaeM7RdAw9PtlVUmNP/NRspOTIynxmWvEF/2I3Am/AF+opx+jXsu5n9SMLWsJPaOlM4c2OKJIH+nIanlH95Wu4ebGIEPG0RdWr4Yb16116SNlG0/CwCZttKp4l1L6BQVppSCeDCdconSjMG9MFYA6/AIlaPFt3RIbEFgM0YF5GuU5K35nLJWNpCtd6tFx19hMjp85G1ojAOsG+Sg/7jFpZXdOFuJTmPtckLZukQlyMJncX5KsqsPzr0BTkwKpE52s3o9tVGQwaeVza0Dip1T/5xb6nqbCq2fLgrppYUo6nw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Stefano Stabellini <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Julien Grall <julien@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Mon, 29 Nov 2021 13:56:41 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 26.11.2021 13:34, Andrew Cooper wrote:
> The function pointer cast in hvm_vcpu_initialise() is undefined behaviour.
>
> While it happens to function correctly before this point, it is not
> incompatible with control flow typechecking,
DYM "is now incompatible" or "is not compatible"?
> so introduce a new
> hvm_assert_evtchn_irq_tasklet() to handle the parameter type conversion in a
> legal way.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> ---
> CC: Jan Beulich <JBeulich@xxxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Wei Liu <wl@xxxxxxx>
> CC: Julien Grall <julien@xxxxxxx>
> CC: Roger Pau Monné <roger.pau@xxxxxxxxxx>
> ---
> xen/arch/x86/hvm/hvm.c | 7 ++++++-
> xen/arch/x86/hvm/vlapic.c | 2 +-
> xen/arch/x86/mm/shadow/common.c | 2 +-
> xen/common/domain.c | 2 +-
> xen/common/keyhandler.c | 6 +++---
> xen/common/livepatch.c | 2 +-
> xen/common/stop_machine.c | 2 +-
> xen/common/trace.c | 2 +-
> xen/drivers/char/console.c | 2 +-
> xen/drivers/passthrough/amd/iommu_guest.c | 2 +-
> xen/drivers/passthrough/amd/iommu_init.c | 4 ++--
> xen/drivers/passthrough/arm/smmu-v3.c | 6 +++---
Wrt my remark in an earlier patch - any reason that here you do touch an
Arm-only file?
Jan
|
