[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/hvm: Drop .is_singlestep_supported() callback


  • To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Fri, 14 Jan 2022 08:41:24 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hs33qj7qQ+TYRtu7Zjl1jDgRrZgrWZI3JPy7qelbQIw=; b=GyJD9XkEHpo0nbLzTNestPFaX6j5VFzwrxpfB4bjsooYbqun723QwHFFuA0yBcSlAs3phwMqEbMYyp80sz1VrGmffH+g0tm4LdAkvuOT9oZC7kKT/5nOmD9VeWRkvtXb0a30f0wmgoiHnofkp1jPVjSCqMAb5UP3UCubqpMe0QBqmGfq+3pKHpLmcg1R+Oj1XhyoHuKVDFUmA7gMJPqbZDTxtNdBeR5WWWjwAVVPajf3c3AOABtLpVV1qzLDS9hejD+xhFmKruaOxZbApirxjkf21L2ji24yYMWjLitsyX+FycPq5vQBILOO9el+7qlulPB+ly5EoIs3qQ4P2GP18w==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iq/V3DxprBFUol8WG+9FEko+JfDw6pfCk2g/0fSbXfsJNKdCouRuQFA2WU97M3wwrBo5O31wvg8sI/Qgr9kXEPYP9J6AXhugd6N0L8oYf8xJMC1yxSQHw2QFe5NK1l2BzsI+C9YDx+NbkWy6fsSvr892VNvEJqEji6Y6CNnnnT1lRT/SjtdtminqBJhGMx5H+F7xecg25wijlDQJ0cjBCrkVDvngEiHDYgR9KBAygzy1gYHajhXaiAureX5Y3BcJuJXLmgAjp3528YKAKacfPveSu3qKI6D/gsemYB5trhRXFqpx4QYXWjJiC7VQC9+y3iCRopLLZiwkzk1TJv8a2w==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>, Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 14 Jan 2022 07:41:50 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 13.01.2022 19:48, Andrew Cooper wrote:
> There is absolutely no need for a function pointer call here.
> 
> Drop the hook, introduce a singlestep_supported boolean, and configure it in
> start_vmx() like all other optional functionality.
> 
> No functional change, but rather more efficient logic.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.