[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] x86/hvm: Drop .is_singlestep_supported() callback

To: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
From: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>
Date: Fri, 14 Jan 2022 09:30:15 -0500
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Jun Nakajima <jun.nakajima@xxxxxxxxx>, Kevin Tian <kevin.tian@xxxxxxxxx>
Delivery-date: Fri, 14 Jan 2022 14:31:11 +0000
List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On Thu, Jan 13, 2022 at 1:48 PM Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
>
> There is absolutely no need for a function pointer call here.
>
> Drop the hook, introduce a singlestep_supported boolean, and configure it in
> start_vmx() like all other optional functionality.
>
> No functional change, but rather more efficient logic.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Reviewed-by: Tamas K Lengyel <tamas@xxxxxxxxxxxxx>

References:
- [PATCH] x86/hvm: Drop .is_singlestep_supported() callback
  - From: Andrew Cooper

Prev by Date: Re: [PATCH v2] x86/HVM: convert remaining hvm_funcs hook invocations to alt-call
Next by Date: Re: [PATCH 3/3] x86/spec-ctrl: Fix NMI race condition with VT-x MSR_SPEC_CTRL handling
Previous by thread: Re: [PATCH] x86/hvm: Drop .is_singlestep_supported() callback
Next by thread: [xen-unstable-smoke test] 167690: tolerable all pass - PUSHED
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.