[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 06/13] vpci/header: implement guest BAR register handlers
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 8 Feb 2022 10:48:00 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sMCNwo8UOrbIlwP7L8+4ukTLhfXLpoJj/Xl9xyg0R5w=; b=RyL8M9iYFHjI9KDGCvSA1sIMPZiaNMp8yO+fpz0OpnnYviXwvXcjR7qKel8BJrdoxr/UQEy4gpLFhE3ct4ttoBt3E5VlK9uWizQ3roVgvMQOWFCOKfVXlIvGCXV4e3gJchbUfJx5/nuebQkopOzIhS6zeSsCZrhXV1434f85WtEhtD++dnkfW38C4gTwvq3cQzrN/nVJ+YduMQUnJRHUiEe/USkm1jYBvuhtB0t43FIMzcaohAcsvp38flwBNiI5zWZ2S6Mam0mJvUr+Zgb/0j48EVkwVpBGjDjxTW8mKyLD4bRSjAZA8bSdH5AZPBik+BmWGirjk02bBvNGEJ486w==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CF3iqnVHKWhqTLvU9SJLiga69w8PJ3lBnQ8p1XSJcThZe31T4FQM6sPZS6LHXh4aj+/GldbrpFmCnO1dACv40oFRuA6Eikk2UOv1krl8apqwYsqpdl4DE7ALb7X8dRpP0IQlpBSlUI3v1X4Ky74ScBnV7n7D9m2QPRQBHla0Qs6qnH9XyNYnaf3SdmgGkCZanmmkLPhDRJJnTYn6vnE4/kOiZ2QBbPEqxioTEaT+BPmE2RJtgH8gjgcSQf5D2c8IG6s7LEjnrLGrZzIhMC6mifmiB1eeSOHyODv8XWuYJyHaxPzpvaiQomOqfhQYXIZ0A/bFcwvmGl/P7MMJbEn2Yw==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 08 Feb 2022 09:48:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 08.02.2022 10:31, Oleksandr Andrushchenko wrote:
> On 08.02.22 11:25, Roger Pau Monné wrote:
>> On Fri, Feb 04, 2022 at 08:34:52AM +0200, Oleksandr Andrushchenko wrote:
>>> @@ -516,6 +594,11 @@ static int init_bars(struct pci_dev *pdev)
>>> if ( (val & PCI_BASE_ADDRESS_SPACE) == PCI_BASE_ADDRESS_SPACE_IO )
>>> {
>>> bars[i].type = VPCI_BAR_IO;
>>> +
>>> + rc = bar_ignore_access(pdev, reg, &bars[i]);
>> This is wrong: you only want to ignore access to IO BARs for Arm, for
>> x86 we should keep the previous behavior. Even more if you go with
>> Jan's suggestions to make bar_ignore_access also applicable to dom0.
> How do we want this?
> #ifdef CONFIG_ARM?
Afaic better via a new, dedicated CONFIG_HAVE_* setting, which x86 selects
but Arm doesn't. Unless we have one already, of course ...
Jan
|
