[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 06/13] vpci/header: implement guest BAR register handlers
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Tue, 8 Feb 2022 09:57:12 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/lbE0Vy9LotVTaHSUinpUIrOA45ndVUqXBaJpAX6ik0=; b=He/OM70yrJAB5s4CWbwDZOGsROnhHCkc3K5hjLOWfMrVmvDT99ZhBKkFY8j3lWz+GLKc5wMJp+8Vd8yEXjIop0fzuyKbh9yZVZnuRsxByE6wD+Y/AAY7a16AzfrlQm3Jzqe2IcxEvZaYM+RvwqYbSWex8Yt/Bre66OAbLXEEG5OBcS13zCXIqszwda8XCws2NIfNYVfBtW0EhNWn9nBozM1HDHQ1thOTdBnbjgEnFoDGGpmC1+DgWBJOZO9FZs0jjwXTqjZQW42OyYKPPmpr6VXqGM9h2NfOkdwSZCjiCw3q9Ijw5X7no3msjasKTlxwtCun3kRBOIkFPBdVYjzj+g==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ADO1FSrAKn/1KfO9V5NsjP9zXze32SfzPFdZdjbbb+kkfkLRd6iHiVTQQ2hzfpQMNKlOqCZp/kf53bo3rNjMaeeqgS/KgqM6fBF6cBQmHG9auZT+7d2sz4GK7V6WEi5ohWBjOR7qSYZ6Cb3ZKlGvj3Q+65z8g9kPOoY4Fg4DItWfeAZ6Msm5RRx0HXD6fEY/GlFW2+FWzvjbwQ+79RJeyV3Qr9PlKcEd4ksB5N0R0EbLC6yF+0T0NH26DKehW5XlKleJq1spyit1lm81afGTstFbuE9e7xlE1qRKsNGasZQQpN5jt9a1qb5M5h1KOxDHl64oryXelGYCQyLi6Rgf6g==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, "andrew.cooper3@xxxxxxxxxx" <andrew.cooper3@xxxxxxxxxx>, "george.dunlap@xxxxxxxxxx" <george.dunlap@xxxxxxxxxx>, "paul@xxxxxxx" <paul@xxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Delivery-date: Tue, 08 Feb 2022 09:57:22 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYGZFd6D+qnME8W0+wTH+v8YZ8DayJaJYAgAABnACAAASVAIAAApGA
- Thread-topic: [PATCH v6 06/13] vpci/header: implement guest BAR register handlers
On 08.02.22 11:48, Jan Beulich wrote:
> On 08.02.2022 10:31, Oleksandr Andrushchenko wrote:
>> On 08.02.22 11:25, Roger Pau Monné wrote:
>>> On Fri, Feb 04, 2022 at 08:34:52AM +0200, Oleksandr Andrushchenko wrote:
>>>> @@ -516,6 +594,11 @@ static int init_bars(struct pci_dev *pdev)
>>>> if ( (val & PCI_BASE_ADDRESS_SPACE) ==
>>>> PCI_BASE_ADDRESS_SPACE_IO )
>>>> {
>>>> bars[i].type = VPCI_BAR_IO;
>>>> +
>>>> + rc = bar_ignore_access(pdev, reg, &bars[i]);
>>> This is wrong: you only want to ignore access to IO BARs for Arm, for
>>> x86 we should keep the previous behavior. Even more if you go with
>>> Jan's suggestions to make bar_ignore_access also applicable to dom0.
>> How do we want this?
>> #ifdef CONFIG_ARM?
> Afaic better via a new, dedicated CONFIG_HAVE_* setting, which x86 selects
> but Arm doesn't. Unless we have one already, of course ...
Could you please be more specific on the name you see appropriate?
And do you realize that this is going to be a single user of such a
setting?
> Jan
>
Thank you,
Oleksandr
|
