[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] x86/Intel: skip CORE_THREAD_COUNT read on family 0xf
- To: Roger Pau Monné <roger.pau@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Fri, 11 Feb 2022 12:05:40 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=npim5LqAP5/y355XR0wWSnzCG2KxB7erRmW8EKAG2MQ=; b=e2oZrrIgIq/Q7rk00yxevEfsnAkmMjOQjanbAkP2ugbRP9ybJp3SaKbLZyMQr82+Sg9mnzmoqWF7miQbbuQS0aYHLb1fVIbD5/rehzDYm989yWNtp26PC51DzWjQgNc7ivld2nFvdCNEV9SbDehKd6v53+ENuv9nHV6p07Q03ZuAeIUz3H77XsJk91vVbR/uFiYrYoFV+zaU+woT5MSB8Wz+5NgmeRJmnSIvilnKItP3QJCtw9RMaswqdPy/5+bYp1xwZm+dnGm7Q+mrsXOTm4DBbqsRQu2vESbwR3wgTkD4kNGX32YfcU7Dmsf1TE5mU2BIAo6Kz7n4FMFUEb0sIQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i1yMJNkCKZZ0K17W0P3LKS12Nx+UnCPqorCFLC6L6VoTDTxOxPXIBMsf85n8nYOEkjsDq2a8o8RYb8cdsrHwYZM64vc6pekocZ+nCUXfbNZU/E1W1Bkze3Dmmdgtz0Y08lcxq0TKQmZ/pu7sNWPLOrSV49CXPYoX7b9Vav/GkU5AiduBpkNYo1oRrFXn83symi4dCHS8kZaf/u/wVVy8FyWsOdHmz4Ih04j9i9RKMaoPmEVhksmXCdCZ/WKeTTj+cP5Q1xqEu+FX4x6OJIplp3qhPWL+RAabUYcYCTJzViAEcvkPgVRsKKn43bJbBs2e7MZRU1jWwMGBFYrelt8y9g==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Fri, 11 Feb 2022 11:05:51 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 11.02.2022 11:58, Roger Pau Monné wrote:
> On Thu, Feb 10, 2022 at 03:56:12PM +0100, Jan Beulich wrote:
>> This avoids an unnecessary (and always somewhat scary) log message for
>> the recovered from #GP(0).
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> Acked-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>
Thanks.
>> ---
>> Perhaps even use "== 6" in the family check?
>
> I think it's best as is. Even on family 6 this seems to be supported
> only on model 3f? (Haswell Xeon E5 v3 and E7 v3?)
Well, ...
> The comment also seems to note this is mostly undocumented.
... this same comment says "Nehalem and later". And this also
matches my observations (and, given he has written the comment, quite
clearly Andrew's as well), no matter what the (notoriously incomplete)
SDM Vol 4 may say.
Jan
|
