[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/16] x86/P2M: derive a HVM-only variant from __get_gfn_type_access()


  • To: Jan Beulich <JBeulich@xxxxxxxx>
  • From: George Dunlap <George.Dunlap@xxxxxxxxxx>
  • Date: Mon, 14 Feb 2022 15:12:51 +0000
  • Accept-language: en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ya0w5Pm8lt2K4enA1pVPf8WWJQx24SVk5IOLZ248c+8=; b=FwqCHiPpCxWbr2nwLxQkNvdH9nUj+whJe5s1rzq2b8ighvwubvYADFqnHZc1cLnEL93X2gqGe6eDNlFuHFOukOOYKFhYdjL49vtcUXVD3Zuu+7HKTwi5mx1uCIqFKu86IAOF5yU4kBkdykDXEbDOHstfAOOpzUiixhEzpyhZUWmknFnATuVoiZao8WQxFmSG74/HHTjDD/2WGS2cUz88Se02D5MoqNdRwZHxbpe3acQYeedEli6pqaHKFjSceOF4OD2ZI+0H5AakoMbB4FaPRxCku5yv63NCXU0E13p2gn05CrJ6WcvIpWwgZm7kETAIVLmH76CRPbViJqvz9pehBw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QRVsAmopmxnOt+F73iGa0QKDz2M/zEsKXJM1dOEjmtokyy+X2h2+lDZhTJ/WqPImIJy6jPSULMBHlesT7onD/AE2gKnLr7AVYwj9ERDWGrQbB7aL6YYcA1vRbybcmucgugxCxqoyXK6OdPqKiApSERk7mEKf+CjeKxcAM/GhtrB3Eer0GlU1OXxpwGnucdv713Y1aM5SgmxVWjw9ghoCAQd21cnhGrMl+o7sRF7FYrIdPFyOTbfhlLW6bsxLwVQ5Y7Hv1rlttKwn1/iqcaS9ky5BpXCoKYiuQ02y8SFuZ3yF9n/sd4isqc3hfHr8+JaxECzGEyUOjtRhCHunJ2j/2A==
  • Authentication-results: esa1.hc3370-68.iphmx.com; dkim=hardfail (body hash did not verify [final]) header.i=@citrix.onmicrosoft.com
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "Andrew Cooper" <Andrew.Cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, "Alexandru Isaila" <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 14 Feb 2022 15:13:04 +0000
  • Ironport-data: A9a23:LIa7n6g1YbTBVrVYDNKV1RnRX161bxYKZh0ujC45NGQN5FlGYwSy9 lOraxnFY6jUMyawOYxoOc7lxf41yZSGyNFrHQJr/n80EytEp5OaCdqQdhuqYCmfJMPJFhw6t cxOZtCccZpuQyPV+hn1PuSw8SZy2PjUGrCiA76cZioZqWOIMMsEoUsLd7kR3t446TTAPz6wh D/SnyH+EA/9h24raTlJ4fLa9Bk2t/qusmlD7lAzbq5F5wSFxiBJXc4Tfa2/ESD1E9JedgKYq 0cv710bEkfxpUpF5gaNy+6jGqEyrzq70TGm0hK6YYD76vR5jnF0gvZT2MY0Mx8N0W3Txowpk r2hiLTrIesXFvyU8Agie0Ew/xFWZcWqL5eefBBTGeTKp6H3WyOEL8dGVSnaDqVBkgpDOklc9 ORwFdw4Rkvra9RaYl6MYrIEaswLdKEHNW6E051q5Wmx4f0OGfgvT0hWjDPxMfhZas1mRJ7ji 8QlhTVHRQ/cYDtpAWYuU9E4gsKyvnPfdgIftwfAzUY3yzC7IA1Z1bHsNJzee8CQRNUTlUGdz o7E1z2nWFdAboXZkGfbtCL37gPMtXqTtIY6O7C/7PFnxnGOwGgaEDUdVEehoOn/gUm7Mz5aA xJIp3R+9PJtnKCtZtj9bR+Z/yaDgkdCePdpH8kas1ynyIOBtm51AUBbF2UcObTKrvQeWTUv3 0Shg9DtCDpgobCRD3ma89+8pDKpMCkRJEcIZDMIQAUI5dXuusc4iRenZs57EbS+h9n8EyzYy TGWoCUwirMfgNRN3KK+lXjlqT+xopnCTiYu+x7aGGmi62tRdIOjIoCl91XfxfJBN5qCCEmMu mAenMqT5/xICouC/ASSRM0dEbfv4OyKWAAwmnY2QcNnrW70vSf+I8YAu1mSOXuFLO4tYiPqR mnoiDoKp5lNGWGSZ49yXMWuXpFCIbfbKfzpUfXdb9xra5d3dROa8CwGWXN8z1wBg2B3z/hhZ M7zndKESC9DVP85lGbeq/I1jOdzrh3S018/UnwSI/6P9bOFLECYRr4eWLdlRrBotfjUyOk5H js2Cidr9/m9eLCkCsU02dRKRbzvEZTcLcqow/G7jsbZfmJb9JgJUpc9O48JdY1/hLhynezV5 Hy7UUIw4AOh2SGYeVXXNyg6M+mHsXNDQZUTZ3JEALpV8yJ7PdbHAFk3K/PbgoXLBMQ8lKUpH pHpiu2LA+hVSySvxtjuRcKVkWCWTzzy3VjmF3P8OFAXJsc8LySUqo6MVla+r0EmU3vo3fbSV pX9j2s3t7JYHF88ZCsXAdryp26MUY81xr4jARuQeoMLEKgumaAzQxHMYjYMC5xkAT3IxyeA1 hbQBhEdpOLXpJQy/sWPjqeBx7pF2cMndqaDN2WEv7uwKwfA+W+vnd1JXOqSJGiPX2Lo4qSyI +5SyqikYvEAmV9Ltat6Eqpqkv1it4e++ecCw1Q2BmjPYnSqFqhkfiuM0/5Qu/Af3bReowa3B B6Co4EIJbWTNcr5O1cNPw55PP+b3PQZl2CKv/Q4KUn3/gFt+7+DXRkANhWAknUFfrB0LJkk0 aEqv8tPs16zjR8jM9CniCFI9jvTcixcAvt/7pxDWd3lkAsmzF1GcKfwMC6u7cHdcchIP2krP iSQ2PjIiYNDyxeQaHE0D3XMg7ZQ3MxcpBBQwVYeDF2Vgd6Z1OQv1Rhc/DlrHARYyhJLj7B6N mRxbhAnIKyP+3FjhdRZXnDqEAZEXUXL9kv0wloPtWvYU0j3CTCdcDxjYb6ArBID7mZRXjlH5 7XJmm/qXAHjcNz1wiZvC1VurObuTIAp+wDP8Cx98x9pw3XujeLZv5KT
  • Ironport-hdrordr: A9a23:zcCeSqN/smnxucBcTsWjsMiBIKoaSvp037BN7TEXdfU1SL39qy nKpp8mPHDP5Ar5NEtOpTniAsm9qBHnm6KdiLN5Vd3OYOCMggqVBbAnwYz+wyDxXw3Sn9QtsJ uIqpIOa+EY22IK7/rH3A==
  • Ironport-sdr: /GTN7gG647DFo7IyS58RPp7v+teqANUNWKd2u0SCon/bvIhZCmmTB+5dTS2FbstEn470I9vgQ5 pvwshnniEa78BOsB/PVWo78NRn0OF9U3dgJscvT9fbxhTas1tE4ShSCnYgODizkLY7PBKEgrv3 aDhZfsrX45K6D9XtGkN68z9rWmK2udFJO+8hITJAZ48a0upZn5epXPFDkgCC6XaDpNfwwonB4n 7CiNSUEnWCi40NZN5TuA+dqfVLU7+493Scd2vZDrHdLi0dSXjfu1TNdgB54d91Wq3ayUrs4JdO VEcQfiH6vLRsk2/MdVHquaZN
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHXcbiZRXYa712FeEi5bV+pycTuo6yUhy4A
  • Thread-topic: [PATCH 11/16] x86/P2M: derive a HVM-only variant from __get_gfn_type_access()


> On Jul 5, 2021, at 5:12 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
> 
> Introduce an inline wrapper dealing with the non-translated-domain case,
> while stripping that logic from the main function, which gets renamed to
> p2m_get_gfn_type_access(). HVM-only callers can then directly use the
> main function.
> 
> Along with renaming the main function also make its and the new inline
> helper's GFN parameters type-safe.
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>

Nit in the title: I read “HVM” as “aych vee emm”, and so I use ‘an’ before it 
rather than ‘a’; i.e., “derive an HVM-only…”

I feel obligated to mention it but I’ll leave it to you whether you want to 
change it or not:

Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

Attachment: signature.asc
Description: Message signed with OpenPGP


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.