[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/16] x86/P2M: derive a HVM-only variant from __get_gfn_type_access()


  • To: George Dunlap <George.Dunlap@xxxxxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Mon, 14 Feb 2022 16:20:06 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PUErQLu02xx2/Pvr+vZNI6PGIhOoW+pkVjD63t1mMWM=; b=mRZRq1bQCev6F0+s7DXRI1hrQ9Wp8tVN4B8XxSE/LlsYB+GD71MPm7Rd219ndY0S/N0ErSNViP8v8JFrVIU3riMA1uuCKEondTaeS4E4U0FsduVBQjxzzVj5EdKWKcxkihlroVQMGKsyM6JkrnuWQBVfTtj/96xG7DJc2TF+aZBUkp5lR3qtEEtwkwz0hQbcDZ/9gqVDLO3482x6kKWriSsNWlkraV6QXZOrkcM0RDqzaGv0R319SBqXuCKkpIVsC4vnIJSMn3EwKoBEfhUUk4mpQThnxvL0iKsWoPboZHZzQ+G/Pb9TAFNBH7oIEr0AzuYUM5rf5xXpBzlQi9L6Tg==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VVIAkVAkJgsOeo3o7criCj5XsA19b0lnNMAQFQstDxPqd1g4Lkvuw4584ggJe8jm2vhMYgYtJ/ksask8aUqAR0pvB1nYcmVnf1AcnPV3sUuxk5uHMGO6FEY3DnzQojTEfri0kHd1O/njXT8tPVIwymgiX/fQB104Em2PAyGCPzcDwzLFe9wl+IvjGWLqSljO1RXtVIghKTTeo4EbZUMAebbkwGmtB6UPcEyv2CBUrEBCucvT9zQ5ZrWKiF/plDgq2raxA79O2VAvS1L/EGtxb5AjVhACWmbq5nYHJ7C05kzO1zH0eljvd9Iy20W1Vvbw4IPh1xaT8ZXyg5zWoTNcLQ==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, Tamas K Lengyel <tamas@xxxxxxxxxxxxx>, Alexandru Isaila <aisaila@xxxxxxxxxxxxxxx>, Petre Pircalabu <ppircalabu@xxxxxxxxxxxxxxx>
  • Delivery-date: Mon, 14 Feb 2022 15:20:18 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 14.02.2022 16:12, George Dunlap wrote:
>> On Jul 5, 2021, at 5:12 PM, Jan Beulich <JBeulich@xxxxxxxx> wrote:
>>
>> Introduce an inline wrapper dealing with the non-translated-domain case,
>> while stripping that logic from the main function, which gets renamed to
>> p2m_get_gfn_type_access(). HVM-only callers can then directly use the
>> main function.
>>
>> Along with renaming the main function also make its and the new inline
>> helper's GFN parameters type-safe.
>>
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> Nit in the title: I read “HVM” as “aych vee emm”, and so I use ‘an’ before it 
> rather than ‘a’; i.e., “derive an HVM-only…”
> 
> I feel obligated to mention it but I’ll leave it to you whether you want to 
> change it or not:

Thanks - I always appreciate clarification on my, frequently, improper
language use. In the case here, however, I know people saying "aych"
as well as ones saying "haych", so I'm always in trouble to judge
which one's right (and probably both are). I therefore decided to
simply drop the "a" from the title, which I think still leaves it be a
proper one.

> Reviewed-by: George Dunlap <george.dunlap@xxxxxxxxxx>

And thanks again.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.