[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure
- To: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 15 Feb 2022 13:49:19 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ks5G3+K9agsJFJ8Q5UpQ/uwTa+dFY0jG4w2XFjRM/Ng=; b=UYVI4G/H+BNT29Q5cknS8TRihhEmhUgwmd+wks7Z2ntBbefLyFD8QYwPtbHNcHkvh7+Es0vV4KUY5D7t6RMeF02DgsiP23bfc7gg24o6T+ajQrk0/bgC3XpXePrswjYfxsN5Q8GGRTlJ6zHEthKkfNLskBmDNLhX7Ln8ud7Oq3IDxa0LPBw7DH9OP9nkRGW3shBztBHfSzDcgHUsyXC6vOPCMADC7HlESxB7b4cmucU2f/wjszRX+lQ3WcJI00QRRHvukC2wyrbEj/2eY54XuviUyDKey4ueCz6vtICpyShO5j4nipsNRBHZb5iYc3C1fmHGEahdaO+4/pTgQ/kWDQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LwhzS2HsKDHOTwaBU2fyNTd//PrJfJfLmOGkGYzjgnj66CBS/SXHf1WGfkODvcA57xqBeQODjwxYHcQepDvPHV8a/LxBng1Y14T/ECeyBtr4G+i1I7LDdvFW2hKjaPdrG3idkO4DWPYPq9cb3SlqsT6lC6SCqDCbRM1CzB4qmlRvzVdz7B4VLRsMhxVAgqHwUeILhJpb/sRJGnEZQBQReT5v2UbMvsfn2rvp6wcTdeP7CgHXoVjoE5RyCNSgcWnIphJLE/Joz1JN7rVu0Nx6znEVcNQR12so0Fop7/C2Z+xbjoEv5xjOSiddEJRU5bLHM6skHAlEj1qmKRgSwFkgzQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>
- Delivery-date: Tue, 15 Feb 2022 12:49:28 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 15.02.2022 12:54, Oleksandr Andrushchenko wrote:
> On 15.02.22 13:50, Jan Beulich wrote:
>> On 15.02.2022 12:45, Oleksandr Andrushchenko wrote:
>>> I'm on your side, I just want to hear that we all agree pcidevs
>>> needs to be converted into rwlock according with the plan you
>>> suggested and at least now it seems to be an acceptable solution.
>> I'd like to express worries though about the conversion of this
>> recursive lock into an r/w one.
> Could you please elaborate more on this?
Not sure what to say beyond the obvious: At the time of the conversion,
there certainly was an issue to be solved. You'd need to solve this
issue differently then. Plus you'd need to make sure that no further
incarnations of the original issue had been there or have been added in
the meantime.
Jan
|
