[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Date: Tue, 15 Feb 2022 12:56:54 +0000
- Accept-language: en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0qU4sQkyqUjQnwqBOMm9sNau7Cji4hxy1oJP7CcMdoE=; b=i8/nGRTsRRY8q6LONUPOvTvXuFJ3HwQmaBRJfwOkOQTDtxxDp49Xf5dq7ReW3iiMDe81ti2bbtQcAQ5QZ8eoRu+5N18ehhYUQjBdQSQVfYxGlFx+loTsk5ZccTbQ2Q7UuGgXbh3KO90cU7XbC2q9zFFSacQ8eEBWEKsxI06cdpJbTl5Awbm5qifvs/xYcwA4FJPRtfrzP99IUqGYl8sP/WCobzSdokTs0+4TGvxrSUCL9NgonUjE3Suj2QqfH1CsxL1CLBVx/Ltk0LSqFFmBm56RU2U9JFI5c4poQ8a4sXer6UlghDT5Pqrv4jmEJFr6/MHNVqpsVNa2RW08WB/FxQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YIMy1RqA0bpPgbKnVaCXOW9Qc5EoqaatsCm4E6ZheZ5x6eKu/gRvawY9r/fEhnxwrbiNylCcCJtMdLQWb0ndvWwY168amord4eOw15CjkePqniyNrifadYwvXXj4OGV4J3/fl9FkDlnn33cQBa+wZUeGq2kSjaUpokxzPyjMGOuhPNRbVc3JvAVo/Yx4nyFFbGSenv+QAxb1daot9t17dXGW5S1L3cRxUw2FaR0g4QU7ilV13dK5YB+bFtoV73fR6G1d/m5nPy8te7Bmgntn/FP4oILl+2sldV5BoJFPU0vlq3N6BC6kUTsNnauPtii8IQb24bZI8n8TX7zJJF5NOQ==
- Cc: "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>, "julien@xxxxxxx" <julien@xxxxxxx>, "sstabellini@xxxxxxxxxx" <sstabellini@xxxxxxxxxx>, Oleksandr Tyshchenko <Oleksandr_Tyshchenko@xxxxxxxx>, Volodymyr Babchuk <Volodymyr_Babchuk@xxxxxxxx>, Artem Mygaiev <Artem_Mygaiev@xxxxxxxx>, Bertrand Marquis <bertrand.marquis@xxxxxxx>, Rahul Singh <rahul.singh@xxxxxxx>, Roger Pau Monné <roger.pau@xxxxxxxxxx>, Oleksandr Andrushchenko <Oleksandr_Andrushchenko@xxxxxxxx>
- Delivery-date: Tue, 15 Feb 2022 12:57:08 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYIkOs9pmsZb0l5kefj1m3qdTVCayUboeAgAAGwYCAAAeVgIAAAZQAgAABlwCAAAEVAIAAD0CAgAACHAA=
- Thread-topic: [PATCH v2] vpci: introduce per-domain lock to protect vpci structure
On 15.02.22 14:49, Jan Beulich wrote:
> On 15.02.2022 12:54, Oleksandr Andrushchenko wrote:
>> On 15.02.22 13:50, Jan Beulich wrote:
>>> On 15.02.2022 12:45, Oleksandr Andrushchenko wrote:
>>>> I'm on your side, I just want to hear that we all agree pcidevs
>>>> needs to be converted into rwlock according with the plan you
>>>> suggested and at least now it seems to be an acceptable solution.
>>> I'd like to express worries though about the conversion of this
>>> recursive lock into an r/w one.
>> Could you please elaborate more on this?
> Not sure what to say beyond the obvious:
I thought you have something specific in your mind that worries
you and you can tell what it is. Thus the qustion
> At the time of the conversion,
> there certainly was an issue to be solved. You'd need to solve this
> issue differently then. Plus you'd need to make sure that no further
> incarnations of the original issue had been there or have been added in
> the meantime.
>
> Jan
>
Thank you,
Oleksandr
|
