[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 02/11] xen: introduce CDF_directmap


  • To: Julien Grall <julien@xxxxxxx>, Penny Zheng <penny.zheng@xxxxxxx>
  • From: Jan Beulich <jbeulich@xxxxxxxx>
  • Date: Wed, 16 Feb 2022 10:34:50 +0100
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uxH9nhv4gQR4MVu7ewiPz80iqv8Z/8i7K11ftTcI0Xw=; b=OsoVgAVa87+MWBq6BrqlOulWTcYL6nKN0XppiVPGq0FUTIIbeaynnONyj6nVHBq+zSxzv3YN7rjWz8lu4bwuIB84WZk3thOrO++3b7YAVohG6JHfYy4eT3s5kziv9Kz3kdMLRXxNLJSKGuNrTwXT3q7+ZJ9XS5Wey28jUfnIa2jRNIVIqdBGV3BYtckQbbVWxsfoe+h1UB9v4NCPgs+eTS6PP8fhv0OmQ3VclgsE0r6QapP7eFENkwV00BILJstfR3ah+wG7Y0d423OJax6lkDfQXQEu8fJoX+Yw8d8XDPFyDF5AGvkqGWFOmjYLOCdAUIbg8yeTzwho+UWKswMoxw==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Kj3w35qcXL47DYErlKBzSQstTFskAT/BPwyefhmoEIebfND7zcXqLnMh77aa8PDaoJE5ruyxdLzlhh0tTmV+n3/prXGkW2gRh6dNnhhFoz/y1NurTzexe3V5M9yeUbC2RjNvRrr97aFx24FRf5rn4Tf15iwnJhpkgG2MP/PWcxoxGpfC+z+8BmP2ho1v6lSkOKHm9QI/q3dwJBQbO1DpoV2umCpBH43Bj6s5YX0fISHVFKrUls3LyByKyUfvoXwR0DhWp7lVShurXt7LD0mRfcgKyCXHOuVhul/DB5Ox6l9EY0aItrJk3k0NuvirmcZtu1NMci33r2ij1xerPLC2+Q==
  • Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
  • Cc: Bertrand.Marquis@xxxxxxx, Wei.Chen@xxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx, sstabellini@xxxxxxxxxx
  • Delivery-date: Wed, 16 Feb 2022 09:34:59 +0000
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>

On 15.02.2022 21:26, Julien Grall wrote:
> (+ Jan)
> 
> Hi Penny,
> 
> I am CCing Jan to give him a chance to...

Thanks, but ...

> On 14/02/2022 03:19, Penny Zheng wrote:
>> diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
>> index cfb0b47f13..24eb4cc7d3 100644
>> --- a/xen/include/xen/domain.h
>> +++ b/xen/include/xen/domain.h
>> @@ -31,6 +31,10 @@ void arch_get_domain_info(const struct domain *d,
>>   /* CDF_* constant. Internal flags for domain creation. */
>>   /* Is this a privileged domain? */
>>   #define CDF_privileged           (1U << 0)
>> +#ifdef CONFIG_ARM
>> +/* Should domain memory be directly mapped? */
>> +#define CDF_directmap            (1U << 1)
>> +#endif
> 
> ... comment on this approach. I would be happy to switch to an ASSERT() 
> if that's preferred.

... I think I did signal agreement with this approach beforehand.
It leaves the option to use the same bit for something x86-specific
down the road.

Jan




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.