[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 02/11] xen: introduce CDF_directmap



Hi Jan,

On 16/02/2022 09:34, Jan Beulich wrote:
On 15.02.2022 21:26, Julien Grall wrote:
(+ Jan)

Hi Penny,

I am CCing Jan to give him a chance to...

Thanks, but ...

On 14/02/2022 03:19, Penny Zheng wrote:
diff --git a/xen/include/xen/domain.h b/xen/include/xen/domain.h
index cfb0b47f13..24eb4cc7d3 100644
--- a/xen/include/xen/domain.h
+++ b/xen/include/xen/domain.h
@@ -31,6 +31,10 @@ void arch_get_domain_info(const struct domain *d,
   /* CDF_* constant. Internal flags for domain creation. */
   /* Is this a privileged domain? */
   #define CDF_privileged           (1U << 0)
+#ifdef CONFIG_ARM
+/* Should domain memory be directly mapped? */
+#define CDF_directmap            (1U << 1)
+#endif

... comment on this approach. I would be happy to switch to an ASSERT()
if that's preferred.

... I think I did signal agreement with this approach beforehand.

You raised a concern and it wasn't 100% obvious whether you would still be happy if we merged it as-is.

So I preferred to ask rather than merging it and getting an angry e-mail/message afterwards :).

Anyway, this series is now fully acked. So I will commit the series in a bit.

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.