[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] xen/mm: Remove always true ASSERT() in free_heap_pages()



From: Julien Grall <jgrall@xxxxxxxxxx>

free_heap_pages() has an ASSERT() checking that node is >= 0. However
node is defined as an unsigned int. So it cannot be negative.

Therefore remove the check as it will always be true.

Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

---

I have looked at the history. AFAICT, node has always be defined
as unsigned int. So the ASSERT() may have never been useful (?).
---
 xen/common/page_alloc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/common/page_alloc.c b/xen/common/page_alloc.c
index 46357182375a..e971bf91e0be 100644
--- a/xen/common/page_alloc.c
+++ b/xen/common/page_alloc.c
@@ -1441,7 +1441,6 @@ static void free_heap_pages(
     unsigned int zone = page_to_zone(pg);
 
     ASSERT(order <= MAX_ORDER);
-    ASSERT(node >= 0);
 
     spin_lock(&heap_lock);
 
-- 
2.32.0




 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.