[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] xen/mm: Remove always true ASSERT() in free_heap_pages()
- To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Wed, 23 Feb 2022 19:30:33 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lnk8BhE0euBbgas7NdN9bZypxmnI+nHh98BTxTV/fUA=; b=T5yhXWtMw9/o19iqGFKWBftYWQpvZFSV9r8LRDekTUgop6CEfulLOBYF4BQYSxeKlZ0WcbO1LZaL5b5UoL1gNpB4yTBiSCGuNPeHlxTlE1Sobto/tetHrRpQrf65fjpPJHBDWwgt+ZxKkWRSTycMFcfz1TEhp4CHxz0nUiUnZFLNUn7+4LDdNHV27HNFjEKGSgtFJkfXmgX12l0J6OvUOTg79XlbNKeKn+6XlP966v96r4t+jCkI0DKHrjhtqjcP5G9OKDcSCFxwc14BabGaKOD3EA+ljCMVLN3gl8SDClylbBNUP7vI8Knt97+vOFwZmP7qHO4d9/S1Mwb+FkczCA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PaJL+GugevdS6AyUL1F+rYiOEVAdMO40Q/hXsg2EjiOIiaz+RIW6z18St2QplhUDd+99GrHbyp6y5bevXNnIhr+nFC7oxPZ28/akj17FOTHvm9X0uXovuX2ZtjZCtDP6Qc+JS1JODXELKbb+IEndyff+7vFDEH+uJpiZvkm1ke7DmEqOobYKJHo1XZDuZH3aiQEFKrabFolKzLFltLmnA3jv6s5oO8UjyR8CwAQ53KWi10b13zRy7aAmtI4QDh1jNgwY0RWilTq0+O8NzosG4Ghxc7nAhlOj4crw4HhymFCzOeQe59EAcvVAHH15L8GB1fEfoJh2up0BfwgL7e2egA==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Julien Grall <jgrall@xxxxxxxxxx>, George Dunlap <George.Dunlap@xxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, "Stefano Stabellini" <sstabellini@xxxxxxxxxx>, Wei Liu <wl@xxxxxxx>
- Delivery-date: Wed, 23 Feb 2022 19:30:46 +0000
- Ironport-data: A9a23:PM/kvav8SJKwblH0Z+LXR8+pqufnVIFeMUV32f8akzHdYApBsoF/q tZmKWCPO6mDMTb3LdxyOom/9k9Uv5PRx95nGwI4rXw2Hn5A+JbJXdiXEBz9bniYRiHhoOOLz Cm8hv3odp1coqr0/0/1WlTZhSAgk/nOHNIQMcacUsxLbVYMpBwJ1FQzy4bVvqYy2YLjW1nX4 ouoyyHiEATNNwBcYzp8B52r8HuDjNyq0N/PlgVjDRzjlAa2e0g9VPrzF4noR5fLatA88tqBb /TC1NmEElbxpH/BPD8HfoHTKSXmSpaKVeSHZ+E/t6KK2nCurQRquko32WZ1he66RFxlkvgoo Oihu6BcRi9wYJ3CvesgfSNGAhNTLaIZwpHHAUmw5Jn7I03uKxMAwt1rBUAye4YZ5vx2ESdF8 vlwxDIlN07ZwbjsmfTiF7cq1p9LwMrDZevzvllJyz3DAOlgapfEW6jQvvdT3Ssqh9AIFvHbD yYcQWQyNkmcM0cfUrsRILIEw73wuEnTShZBjmCTjvYOyjD36gMkhdABN/KKI4fXFK25hH2wp GjL4mD4CREyL8GExHyO9XfErvTUgSrxVYYWFbu53v1nmluewioUEhJ+fUS/iem0jAi5Qd03A 04J/isjq4Ai+UrtScPyNzWorXjBshMCVt54F+wh9BrL2qfS+xyeBGUPUnhGctNOnM05XzUu0 neAmtr7Ajopu7qQIU9x7Z/N82n0Y3JMazZfO2lUFmPp/uUPvqlq0CLBa9lePpSrn+/YCT6v+ R6KjBkx0uB7YdEw6423+lXOgjSJr5fPTxIo6gi/Yl9J/j+Vd6b+OdX2tAGzAeJoad/AEwLf5 CRsd922sbhWZaxhghBhVwnk8FuBw/+eeAPRjld0d3XK32T8oiXzFWy8DdwXGauIDirmUWKxC KMwkVkIjHO2AJdMRfUrC25WI553pZUM7fy/CpjpgiNmO/CdjjOv8iB0flK31GvwikUqmqxXE c7FLZvxUChCWf47k2reqwIhPVkDnHxWKYT7H82T8vha+eDGOC79pUktajNikdzVHIvb+V6Io r6zxuOByglFUf2WX8Uk2dV7ELz+FlBiXcqeg5UOLoare1M6cEl8W6656e5wIORNwvUK/tokC 1ngAye0PnKk3iaZQehLA1g+AI7SsWFX9yxjZnV0ZQ7ys5XhCK72hJoim1IMVeBP3MRozOJuT ulDfMOFA/9VTS/A9ShbZp74xLGOvjzy7e5SF0JJuAQCQqM=
- Ironport-hdrordr: A9a23:0U8IdK/sJxOgUI9JPhBuk+Fpdb1zdoMgy1knxilNoENuHfBwxv rDoB1E73LJYW4qKQwdcdDpAtjkfZquz+8I3WBxB8bvYOCCggWVxe5ZnPLfKlHbak7DH6tmpN 1dmstFeZLN5DpB/L7HCWCDer5KqrjmzEnrv5ak854Ed3AyV0gK1XYcNu/vKDwReOAwP+tfKH Pz3LskmxOQPVAsKuirDHgMWObO4/fRkoj9XBIADxk7rCGTkDKB8tfBYlal9yZbdwkK7aYp8G DDnQC8zL6kqeuHxhjV0HKWx4hKmeHm1sBICKW3+4kow3TX+0aVjbZaKv+/VQMO0aSSAZER4Z 3xSiIbTodOArXqDyaISFXWqk/dOX0VmgDfIBej8AXeSIrCNWoH4oN69PJkmlGy0TtQgPhslK 1MxG6XrJxREFfJmzn8/cHBU1VwmlOzumdKq59Zs5Vza/pWVFZql/1WwKqVKuZ1IAvqrIQ8VO V+BsDV4/hbNVuccnDCp2FqhNihRG46EBuKSlUL/pX96UkaoFlpi08DgMAPlHYJ85wwD5FC+u TfK6xt0LVDVNUfY65xDPoIBcG3FmvOSxTRN3/6GyWsKIgXf3bW75Ln6rQ84++nPJQO0ZspgZ zEFEhVsGYjEnief/FmHKc7hSwlbF/NLwgFkPsulKSRkoeMMYbWDQ==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYKOShk/ueVOZf6kGfV3gTr3FtFKyhhdyA
- Thread-topic: [PATCH] xen/mm: Remove always true ASSERT() in free_heap_pages()
On 23/02/2022 18:38, Julien Grall wrote:
From: Julien Grall <jgrall@xxxxxxxxxx>
free_heap_pages() has an ASSERT() checking that node is >= 0. However
node is defined as an unsigned int. So it cannot be negative.
Therefore remove the check as it will always be true.
Coverity-ID: 1055631
Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>
Acked-by: Andrew Cooper
<andrew.cooper3@xxxxxxxxxx>
|
