[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/mm: pg_offlined can be defined as bool in free_heap_pages()


  • To: Julien Grall <julien@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
  • From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
  • Date: Wed, 23 Feb 2022 19:38:12 +0000
  • Accept-language: en-GB, en-US
  • Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
  • Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OsNSTOAFzRvtTZXg+Ac4XNrjMuDp1cbY+Z5tYgitLv4=; b=jr+nwk6DMpimgIRhqYAEBGh3hUDHrsMdegCiNwuIMljf+npcO1aSs9GJxRaceWP0Tq6T48bK0yPkCUV+BCINnJutSpyXE2VsAlo8M0omKnWJSAFBgw9XRYDJGuC8MJ60dzoHNr6AIrzCe7sIBpkSK+rl7KTd6voF2pKhS6NzcBbq0tTjI9EGCEiNBPuu2/jJgmuBzaqOOT5oEP3t+tB2QVsm66dAFQ/MuFUUv6cJQX9mUEH/6AI89mxoXSnpTefVT2IsSaKR4bnqB1mgizJ8naS5G0pnAiJQDclveLWV5r05s9Nxu628TI9Kqd8UvIEJUX9VcqO8ZwB70dJEMpu0Ug==
  • Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PiPvpQ1sZUOjAvX7RrzmCzhcjT7bFe+hjustFkG5Xi0aVHMsJ8usdINU0WsC1EyweoD2USHbqYYzxUWTLNP50SLDO1Sac5g1/LBErWG84dW8Gyt59R73pm+WOl4H2Xbdp3/L5MJ6hh0h8cQclZ0dFdqR5o1vrcUEhr4ZJdHbfP9VJuGtwlKDMsybHXQVHH6z5wQlL5Ny3dyUYnzGeuP+1AbjeNup1BF5hYNdCAR/w0UWgmNbkApTlekqJYEi0kVuFlA9g+SKX1nKcCRO5k5Unv/g9ZTEc4lTbXb0fPjyaLkXVwJM3wRewYuP8+IzzLyiid73SJWEmzB+xSbllfhHdw==
  • Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
  • Cc: Julien Grall <jgrall@xxxxxxxxxx>
  • Delivery-date: Wed, 23 Feb 2022 19:38:25 +0000
  • Ironport-data: A9a23:qHT7la/lwAab0UsfnDREDrUDnn6TJUtcMsCJ2f8bNWPcYEJGY0x3y jAZXGyDPvjfYzHwfo8ibty09h5UvpaBnIdlTVNpryo8E34SpcT7XtnIdU2Y0wF+jyHgoOCLy +1EN7Es+ehtFie0Si+Fa+Sn9T8mvU2xbuKU5NTsY0idfic5Dndx4f5fs7Rh2NQw24LiW1nlV e7a+KUzBnf0g1aYDUpMg06zgEsHUCPa4W5wUvQWPJinjXeG/5UnJMt3yZKZdhMUdrJ8DO+iL 9sv+Znilo/vE7XBPfv++lrzWhVirrc/pmFigFIOM0SpqkAqSiDfTs/XnRfTAKtao2zhojx/9 DlCnaawe1obGof1o7siXEBbNgd4foBhwrCSdBBTseTLp6HHW37lwvEoB0AqJ4wIvO1wBAmi9 9RBdmpLNErawbvrnvTrEYGAhex6RCXvFKoZtmtt0nfyCvE+TIqYa67L+cVZzHE7gcUm8fP2O ZZJNWs1N0WojxtnHA8uOr4Vv8GRmyfNVAN/gluKnrhn7D2GpOB2+Oe0a4eEEjCQfu1XkVyRo mbu9mHwEBYccteYzFKt4n+qw+PCgy7/cIYTD6GjsO5nhkWJwW4eAwFQUkG0ydG7l0q/VtR3O 0ESvC00osAPGFeDF4enGUfi+Tjd40BaC4E4//AGBB+l8KrmvjS9LFE/EQFOMd8Dksl1aBsQ2 Qrc9z/2PgBHvLqQQHOb076bqzKuJCQYRVM/iT84oRgtuIe6/txq5v7bZpM6SfPu0IWpcd3l6 23S9EADa6MvYdnnPklR1XTOmHqSq5fAVWbZDS2HDzv+vmuViGNIDrFECGQ3D94ddO51rXHb5 RDofvRyCshUUflhcwTXHY0w8EmBvartDdElqQcH82Md3zqs4WW/Wotb/StzIkxkWu5dJ2O0P RKN4VMLuMADVJdPUUORS9jtYyjN5fK9fekJq9iONoYeCnSPXFXvEN5Sib64gDm2zRlEfVAXM paHa8e8ZUv2+ow8pAdas9w1iOdxrghnnDu7bcmik3yPjOrPDFbIGOxtGAbfMYgEAFas/Vy9H yB3bJDRlX2ykYTWP0HqzGLkBQpUdSNiXciu8aS6tIere2JbJY3oMNeIqZsJcI15haVF0ODO+ 3C2QEhDz1Tjw3bALG23hrpLNdsDgb4XQaoHABER
  • Ironport-hdrordr: A9a23:CQndjKk1BmQF8JH05TtBfNYgYuTpDfOCimdD5ihNYBxZY6Wkfp +V88jzhCWZtN9OYhwdcIi7SdS9qXO1z+8R3WGIVY3SEzUOy1HYUL2KirGSjQEIeheOutK1sJ 0PT0EQMqyIMbEXt7eY3OD8Kadb/DDlytHouQ699QYUcegCUcgJhG0ZajpzUHcGPzWubaBJT6 Z0jfA3wwZIDE5nCPhTcUN1ONQryee79q7OUFojPVoK+QOOhTSn5PrRCB6DxCoTVDtJ3PML7X XFuxaR3NTij9iLjjvnk0PD5ZVfn9XsjvFZAtaXt8QTIjLwzi61eYVaXaGYtjxdmpDt1L9qqq iPn/4TBbU215rjRBDznfIr4Xin7N8a0Q6m9bZfuwq7nSW2fkNjNyMLv/MnTvKQ0TtfgDg76t MQ44vRjesmMfuL9h6NluTgRlVkkFG5rmEllvNWh3tDUZEGYLsUtoAH+lhJea1wVx4SxbpXWd WGNvusrMq+sGnqG0zxry1q2pihT34zFhCJTgwLvdGUySFfmDR8w1EDzMISk38c/NZlIqM0qt jsI+BtjvVDX8UWZaVyCKMIRta2EHXERVbJPHiJKVrqGakbMzbGqoLx4r8y+Oa2EaZ4hqcaid DEShdVpGQyc0XhBYmH24BK6AnERCGnUTHk2qhllu5EU33HNc3W2AG4OSITepGb0oYi6+XgKo OOBK4=
  • List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
  • Thread-index: AQHYKOjWJCDx2mm9mk6Wd3Mq36vJRKyhh/cA
  • Thread-topic: [PATCH v2] xen/mm: pg_offlined can be defined as bool in free_heap_pages()

On 23/02/2022 19:08, Julien Grall wrote:
> From: Julien Grall <jgrall@xxxxxxxxxx>
>
> The local variable pg_offlined in free_heap_pages() can only take two
> values. So switch it to a bool.
>
> Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

I'd argue this might want to go as far as declaring Fixes: 289610483fc43
which really did introduce one bool pg_offlined and one unsigned int
pg_offlined which were the same thing.

Either way, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.