[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] xen/mm: pg_offlined can be defined as bool in free_heap_pages()



Hi Andrew,

On 23/02/2022 19:38, Andrew Cooper wrote:
On 23/02/2022 19:08, Julien Grall wrote:
From: Julien Grall <jgrall@xxxxxxxxxx>

The local variable pg_offlined in free_heap_pages() can only take two
values. So switch it to a bool.

Signed-off-by: Julien Grall <jgrall@xxxxxxxxxx>

I'd argue this might want to go as far as declaring Fixes: 289610483fc43
which really did introduce one bool pg_offlined and one unsigned int
pg_offlined which were the same thing.

I am OK with that. I will add it while committing the patch.


Either way, Acked-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

Thanks!

Cheers,

--
Julien Grall



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.