[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: make embedded endbr64 check compatible with older GNU grep
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 24 Feb 2022 10:21:56 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0FwQSj+Arevjf2KS6yFNQQyXSOwzVDu7YgXqdMuQvho=; b=av0ybdnZDvpbDYYfsT7ncs6mSb9IuC+8orJv1R9m1Ui+fIVNg+D76WmHpNAkk0TC0bcV250Yt5d5WLyCpFzQNNFXmmHo95y7faULCyRRIqEJSbpeFLhpBGJRw/yazzpVyg0KPfgBscQvaUTj/ja5h0cU95pMlMl/pK6ZncHaoLxZ0aTTuVi/rfpfak+/Z1ApjhKFsEB0p6qP4wYOOuE4dqWVHcBvWjIZLSAh/6i+kzvNidn99qTEv9ye5U8U9bmH0xMW40mEtbUz3lYalYJ0YfrRQVRXKdsfooK9f/H/QPHlegFpnwW63dMRBac0y49OoOdCViVT98bjHOAaBAFRaQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M4p4D4qXCDRo5/FcmycoEEaA1DhBPII7bzeIIEpi1vTzWgMgH1iaeyg+19b7wh6l+mFwD/7iZ1xnK0/LueimtXcltmRJEfYBPG4ZXrsR7Y5ZWQ2+zm2jaRRmykU7HB6sgLoqIKiPt7Th59B3A9n0Yj82MQgHtyNaVilZaD5dAABecCa4cIiBIagwX/5axmjVA6TAWvISqtFlarEm5BABJWgE2IcSOWk/Io/eLAW5BHBhrL5yzNqqVrGnbeGH3bNGJDmPpOFrj1l2TWuP5uDYOw9eBW05tLmh+FYfYUMVWCUEEFwtqrvPYCIYMGP2w7sH0OB3HEptJ1+TwGSitpFwgw==
- Authentication-results: esa3.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 24 Feb 2022 10:22:15 +0000
- Ironport-data: A9a23:d0daLqBvWLRfJRVW/zvjw5YqxClBgxIJ4kV8jS/XYbTApG5w0zMFx 2ZJCmuGb/2NM2Dyfoh2a9i+o0IDv5KGmNcyQQY4rX1jcSlH+JHPbTi7wuYcHM8wwunrFh8PA xA2M4GYRCwMZiaA4E/raNANlFEkvU2ybuOU5NXsZ2YhFWeIdA970Ug5w7Rj3tYx6TSEK1jlV e3a8pW31GCNg1aYAkpMg05UgEoy1BhakGpwUm0WPZinjneH/5UmJMt3yZWKB2n5WuFp8tuSH I4v+l0bElTxpH/BAvv9+lryn9ZjrrT6ZWBigVIOM0Sub4QrSoXfHc/XOdJFAXq7hQllkPhWl fVTm7OLRj4IYI+Rn9ZHQwNVN35XaPguFL/veRBTsOSWxkzCNXDt3+9vHAc9OohwFuRfWD8Us 6ZCcXZUM07F17neLLGTE4GAguwKKsXxMZxZkXZn1TzDVt4tQIzZQrWM7thdtNs1rp4STaeGP 5ZCAdZpRAXLRRJ/PUotMbAdx9qEqXflNCN3713A8MLb5ECMlVcsgdABKuH9ZdiiVchT2EGCq Qru72n/Rx0XKtGb4T6E6W63wP/CmzvhX4AfH6H+8eRl6HWRzGEODBwdVXOgvOK0zEW5Xrpix 1c8o3R06/JorQryE4e7D0bQTGO4UgA0fIdwDcMV0w606/T2vgGrXHgeQxoeQYlz3CMpfgAC2 liMltLvIDVgtryJVH6QnoupQSOO1Ts9djFbO3JdJecRy5y6+dxo0EqTJjp2OPPt1rXI9SfML ydmRcTUr5EaloY12qqy5jgraBr898GSHmbZCug6N19JDz+Vhqb4P+RECnCBtJ6sybp1qHHb4 hDofODEsYgz4WmlznDlfQn0NOjBCwy5GDPdm0VzOJIq6i6g/XWuFagJvm0jehszbpxfJmeyC KM2he+3zMUNVJdNRfUqC79d9uxwlfSwfTgbfqq8giVyjmhZK1bcoXAGib+41GHxikk8+ZzTy r/AGftA+U0yUPw9pBLvHr91+eZymkgWmDOCLbimnk/P+efPOxaopUItbQLmghYRt/jf/m04M r93aqO39vmoeLegOnKOqdZLdzjn7xETXPjLliCeTcbaSiJOE2A9Ef7Bh7Qnfo1uhaNOkenUu Hq6XydlJJDX1RUr9S3ihqhfVY7S
- Ironport-hdrordr: A9a23:gCm0D6v3G+wgFp4pQDIFceJ27skC2IMji2hC6mlwRA09TyXGra +TdaUguSMc1gx9ZJh5o6H8BEGBKUmskKKceeEqTPiftXrdyReVxeZZnMXfKlzbamHDH4tmu5 uIHJIOceEYYWIK7voSpTPIaerIo+P3sZxA592ut0uFJDsCA8oLjmdE40SgYzZLrWF9dMEE/f Gnl656Tk+bCBIqh7OAdx44tob41r/2vaOjRSRDKw8s6QGIgz/twqX9CQKk0hAXVC4K6as+8E De+jaJppmLgrWe8FvxxmXT55NZlJ/K0d1YHvGBjcATN3HFlhuoXoJ8QLeP1QpF491HqWxa0u UkkS1Qe/ib2EmhOV1dZiGdnTUI5QxerkMKD2Xo2EcL7/aJHA7SQPAx+r6xOiGplXbI+usMip 6jlljpx6a+R3n77VXAzsmNWBdwmkWup30+1eYVknxESIMbLKRctIoF4SpuYdw99Q/Bmcka+d NVfYnhDTdtACenRmGcunMqzM2nX3w1EBvDSk8eutaN2zwTmHxi1UMXyMEWg39FrfsGOtR5zv WBNr4tmKBFT8cQY644DOAdQdGvAmiIRR7XKmqdLVnuCalCMXPQrJz85qkz+YiRCdY15Yp3nI 6EXEJTtGY0dU6rAcqS3IdT+hSIW2m5VSSF8LAp23G4gMyKeFPGC1zwdLl1qbrSnxw2OLyvZ8 qO
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYKWdr96DvHtmiCE6n5nuoqf1KFayifeMA
- Thread-topic: [PATCH] x86: make embedded endbr64 check compatible with older GNU grep
On 24/02/2022 10:14, Jan Beulich wrote:
> With version 2.7 I'm observing support for binary searches, but
> unreliable results: Only a subset of the supposed matches is actually
> reported; for our pattern I've never observed any match. This same
> version works fine when handing it a Perl regexp using hex or octal
> escapes. Probe for support of -P and prefer that over the original
> approach.
>
> Fixes: 4d037425dccf ("x86: Build check for embedded endbr64 instructions")
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
Looks plausible. Tentative ack, but this definitely needs a full run
through CI before committing. Let me kick something off.
> ---
> If we were to fear -P having a different meaning elsewhere, we may need
> to switch to the respective long option (--perl-regexp).
We can probably get away with -P.
~Andrew
|
