[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] x86: make embedded endbr64 check compatible with older GNU grep
- To: Jan Beulich <jbeulich@xxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Thu, 24 Feb 2022 11:22:17 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=PP5ZeioIF4xFGvxeh3WqJzqQDY3AtgMV8UlX+LI3gwI=; b=FxevyrEAiPqDhple4mVp3luu3hhYlMYblFQH9aMaBKzsIqF8+zHtuTa6hvsUiHOmD+yEoTgWDOZNQxZv96alie5nVL0YNhRTw9Op9il1tGUtTjuQrLGfukvZtanpHbI8SsuMfgHIx53/VVdAOJpSCR7UsfPCOjrkFlEX0FP7M28X5jLTRF54yEYjyVxoJJXTyESuRzTvafwgM3z8fqGiw82TdW85Zv8h/1ODbMv8of1xKFnRC6gKgfhAsNVCexEhI0brXKvOvhfyufT4yIJ/VDjfd/IIsfwfrWyZZ+Kcfok4a4eh5d6U+f46n5oWjXIlmLb3Hd5eYrqyZkljZWam9Q==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P24ve/cuFPPg0A5c491iHpt+sXbZ+9Vq37cSJgGxzAdNm8e9wOuWxg0y5E9UKNkJDSap+XDCh2z+INs/SD9jMGnZBT2hiAwUnrcOdPowzFh2UtBK9nrqOguutE2u/7i4kKD4M3+udtf6N+wqDrPYhsMJY/6MJp9QyQuW6NiSVkLwXkkSUcD21uWcLnZ7bKnRRQZjg3UcNcoOZML7R3GUCKhacb10chDQLpic7wc+1aa4VrPa7MdUntkLME5QFFfhV6SexgXuLLHZwjSKmoIoz5o6QDd+N/pj2eyZ5XzxQd71L9pDs2flu1v0vZb8+kwMSYy9PjuVK4muLuZLXwO+vA==
- Authentication-results: esa2.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>
- Delivery-date: Thu, 24 Feb 2022 11:22:44 +0000
- Ironport-data: A9a23:2+vDZqIHYiIyHaVGFE+Rw5UlxSXFcZb7ZxGr2PjKsXjdYENSgzcFy zMaD2vUOqyMZmTyLd9wPt+39h9XsJKEzoBrTgplqX01Q3x08seUXt7xwmUcns+xwm8vaGo9s q3yv/GZdJhcokf0/0vrav67xZVF/fngqoDUUYYoAQgsA180IMsdoUg7wbRh2NQ02YHR7z6l4 rseneWOYDdJ5BYsWo4kw/rrRMRH5amaVJsw5zTSVNgT1LPsvyB94KE3fMldG0DQUIhMdtNWc s6YpF2PEsE1yD92Yj+tuu6TnkTn2dc+NyDW4pZdc/DKbhSvOkXee0v0XRYRQR4/ttmHozx+4 PMRhbHsUwAjBPXNocUmCUd9E2Y5I6ITrdcrIVDn2SCS50jPcn+qyPRyFkAme4Yf/46bA0kXq 6ZecmpUKEne2aTmm9pXScE17ignBODtMJkSpTdLyjbBAOx9aZvCX7/L9ZlT2zJYasVmQ6qON pdIMGEHgBLocyFpB08lCsIHtsD0j0GiWCRnjkKHnP9ii4TU5FMoi+W8WDbPQfSVQe1Fk0Deo XjJl0zpDxdfONGBxD6t9nO3mvSJjS79QJgVFrCz6rhtmlL77m4ZBQASVFC7ieKkkUP4UNVaQ 3H44QJ38/J0rhbyCICgAVvo+xZooyLwRfJ2T90XtBuKwJCM4j+4PTJaaz4GL8Ip4ZpeqSMR6 neFmNbgBDpKubKTSG6A+rr8kQ5eKRT5PkdZO3ZaEFJtD83L5dhq00mRFooL/Lud04WtcQwc1 Qxmu8TXa187qccQn5u28lnc695HjsiYF1Vljuk7s4/M0++YWGJHT9HwgbQ4xawZRGp8crVnl CJa8yR5xLpTZaxhbATXHI0w8EiBvp5pygH0j191BIUG/D+w4XOldo04yGggeBo3bpxYI2S2O BS7VeZtCHl7ZiXCgUhfOd/ZNijX5fK4SYSNug78NLKinaSdhCfYpXozNCZ8LkjmkVQ2kLFXB HtoWZ3EMJruMow+lGDeb75EidcDn3lirUuOFcGT50n2itK2OS/KIYrpxXPTN4jVGovf+16Lm zueXuPXoyhivBrWOHePqtdLdQhQRZX5bLivw/Fqmie4ClMOMEkqCuPLwKNnfIpgnq9PkfzP8 G37UUhdoGcTT1WdQelWQhiPsI/SYKs=
- Ironport-hdrordr: A9a23:xU8p4avF+4PRrZ8utSZWVjHn7skDctV00zEX/kB9WHVpm6uj5q eTdZUgpHvJYVMqM03I9urtBEDtexzhHP1OgbX5X43NYOCOggLBRuxfBODZogHIKmnT8fNcyL clU4UWMqyUMbGit7eY3OBvKadD/OW6
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYKWdr96DvHtmiCE6n5nuoqf1KFayifeMAgAAQ3YA=
- Thread-topic: [PATCH] x86: make embedded endbr64 check compatible with older GNU grep
On 24/02/2022 10:21, Andrew Cooper wrote:
> On 24/02/2022 10:14, Jan Beulich wrote:
>> With version 2.7 I'm observing support for binary searches, but
>> unreliable results: Only a subset of the supposed matches is actually
>> reported; for our pattern I've never observed any match. This same
>> version works fine when handing it a Perl regexp using hex or octal
>> escapes. Probe for support of -P and prefer that over the original
>> approach.
>>
>> Fixes: 4d037425dccf ("x86: Build check for embedded endbr64 instructions")
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
> Looks plausible. Tentative ack, but this definitely needs a full run
> through CI before committing. Let me kick something off.
Started now:
https://gitlab.com/xen-project/people/andyhhp/xen/-/pipelines/478508459
https://cirrus-ci.com/build/6255196018835456
We're getting chronic networking problems in gitlab right now so that
might require a lot of persuasion to be useful.
~Andrew
|
