[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/time: add CF-clobber annotations
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 1 Mar 2022 15:18:26 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XvD4MMtvcaPKx23Cg8/gsE0qHf/waojcPXGHwdeZSik=; b=NGdgHcKpD+5CqKlbHef9AbZh9bSLGI+vKC+91DcF/Njzs2jc+SYW+QAk3f2+uYiox7JEDemyTp7kWG7XTEvPO2wKE6jDTSo9YPnnJrXHrKO27HdvwWfi9GqU4oEG2F32/V/YBvOP/E4JhSanU/aBBNF0Qob0039MOYS9T/HSY9TlOGJgy6aohUbFK7kEJXOmO+O3ja7UvcwPZCrcfbe1uzDoTAG3LuKiO1cryWpzgoytivH/k8e/47F3OBbS7hG0fxBgZz9KcdBgUr5/NJmLMpexS0RlOw1mNSG0m3mToVa0U9+3vxS6g+fK9J8Iua32pQWb2/0Y12sm3w2lN4V/GA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fexer6soqBZV4SnTpz/iod5RtLEEaCH08Ouxsl4+7UAxFK+7/ta6y1H2edy+E6wvRJn0Lf2lujYtq4fJlW3HoZnZrgWkBHSHfWFwRINytL5rCaXZMWd7B8T7UK3BpjFLDLCLxj1SjvErK/zK/dRSJYus4Z2DUcIMgNxpO+iZ2nO6/PyGkriNZzjluOysDiUFvlvcKjOq0ak5ml7cegOnPE2xNlq72iVH02EDW+bHiDNgsNm/oOqtOrP3lpHd8ikrKdQJwg/8tDTqJFd0K/qxUYE1KGbe239afFt8M2nPQOK8aJriD4j5VGHsMsCcwZqxAEEbcPQbjsdvIAanFZrPtQ==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 01 Mar 2022 14:18:44 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.03.2022 14:18, Andrew Cooper wrote:
> On 01/03/2022 11:06, Jan Beulich wrote:
>> With bed9ae54df44 ("x86/time: switch platform timer hooks to altcall")
>> in place we can further arrange for ENDBR removal from the functions no
>> longer subject to indirect calls. Note that plt_tsc is left untouched,
>> for not holding any pointer eligible for ENDBR removal.
>
> I'd be tempted to include it, for consistency sake alone.
>
> It is less likely to go wrong in the future if another hook is introduced.
Can do, sure.
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> With the commit message, I'm not not certain if this is linked to the
> previous patch.
>
> Overall it looks fine, but I'd like to get clarity on this point.
Converting read_tsc() was discussed (with Roger) earlier on, so I'd
view this as a separate change. As said in reply to your comments on
the 1st patch, how exactly read_tsc() looks like is orthogonal to
the changes here at least as long as it doesn't live in .text.
Jan
|
