[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/time: add CF-clobber annotations
- To: Jan Beulich <jbeulich@xxxxxxxx>
- From: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- Date: Tue, 1 Mar 2022 14:24:21 +0000
- Accept-language: en-GB, en-US
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xaici8cdAXimItpFNgulJa2mXejsU3sDY7hjdE8UlLQ=; b=J4wbyKpoWThswLti/VQ/16UiPZPs8PZaKg1vT5ao1kp3uAwIDtX7QwJiDaAPEZF/kj8eOdP67HVWhuDi5yIgI05b/XiIeM4RRiHCu1J9XqQJmbTZy0cFV144YsYAmRFqCNL1WAyQoB2K4V3dGbajB5kjrSpgln7AN/oOwhsF87yGhTaB7lhZznfrSM2Vjo/JhvfgEWEs9Wm63BagbX56FFfblfwRGWNErG7+Cqt5r32GnQKX6WJab78rvW9ZdJvqNNBdCY2BaVArUzGvbLvyc54u22dt7N+hlrz7OvIEUvw72exSRODiB3bBFyMG4ToR58eBGZbvZDBMQ3G3r1vIkw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PgqthP5GVfvcYFFXb0iWzUAT3RDKoD8Z2XNYajkVkXMpXffcZ2p0pcWNCjQGzFGCiyf24ceIYDOV/U3aaHo7ZVSq0rWml/7MecIew7H4ENz1mEDnUzKlmudlBs2DUVqg220/N4AsWmAUHKUaZp/JS8eiX6cgQIkgp4NcUgA8MGjhKGAa5tORZGZYApfYUm/ofZ6Wnl2fvWMAl7voAk3TIYeEZuzSBXTPRT6TX5xadT0aU/Xbbq3quROdaN8fzIMgIttE6yTclJTwpHsOEjzdtfq0xHFrQ9MKwGwTDBEughjc/ze74fFUW6pYJwktdMzF5pD+Kq75rfBGSEnmdT/wSQ==
- Authentication-results: esa1.hc3370-68.iphmx.com; dkim=pass (signature verified) header.i=@citrix.onmicrosoft.com
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 01 Mar 2022 14:24:30 +0000
- Ironport-data: A9a23:tQ7ICa6zI79f/CF9pXTGTwxRtCXHchMFZxGqfqrLsTDasY5as4F+v mEfDWrQbK2DMTHwKdt1Ot/n9E5V7ZLTnNZhQAY9rS5mHi5G8cbLO4+Ufxz6V8+wwmwvb67FA +E2MISowBUcFyeEzvuVGuG96yE6j8lkf5KkYAL+EnkZqTRMFWFw0XqPp8Zj2tQy2YPhWlvX0 T/Pi5a31GGNimYc3l08s8pvmDs31BglkGpF1rCWTakjUG72zxH5PrpGTU2CByKQrr1vNvy7X 47+IISRpQs1yfuP5uSNyd4XemVSKlLb0JPnZnB+A8BOiTAazsA+PzpS2FPxpi67hh3Q9+2dx umhurSZSAoAObfhg90vVjgfMyNiAohl/bjYdC3XXcy7lyUqclPpyvRqSko3IZcZ6qB8BmQmG f4wcW5XKErZ3qTvnez9GrIEascLdaEHOKs2vH16wC6fJvEhWZ3ZGI3B5MNC3Sd2jcdLdRrbT 5REN2A+N0iZC/FJEgYYVqwskr33umTUYSdJuXSTj6YOsneGmWSd15CyaYGIK7RmX/59jkue4 27L4Wn9KhUbL8CEjyqI9Gq2ge3Clj+9X5gdfJWn8tZ6jVvVwXYcYDUUX1ampfiyimalRslSb UcT/0ITQbMarRLxCIOnBlvh/SDC7kV0t8ds//MSwQCA463Ozh2gNG0lCR5DdOMDl8oxWml/v rOWpO/BCTtqubyTbHuS8LaIsD+/URQowX8+iTwsFlVcvYS6yG0npleWF4s4Tvbp5jHgMWyom 1i3QD4Ca6L/ZCLh/4Gy5hj5jj2lvfAlpSZlt1yMDgpJAu6UDbNJhrBEC3CGtZ6sz67DFzFtW UTofeDEtIji6rnXyUSwrB0lRu3B2hp8GGS0baRTN5cg7S+x3HWoYJpd5jpzTG8wbJpaIWCyP hOK4FoAjHO2AJdMRfUsC25WI553pZUM6Py/DqyEBjawSsIZmPC7ENFGOhfLgjGFfLkEmqAjI 5aLGftA/l5BYZmLOAGeHr9HuZdyn3hW7TqKGfjTkkT2uZLDNSX9YepUbzOzghURsfrsTPP9q I0EaaNnCnx3DYXDX8Ug2dVLfABScCNiXsieRg4+XrfrHzeK0VoJUpf56bggZ5Zkj+JSkOLJ9 Wu6QUhW1Bz0gnivFOlAQioLhG/HNXqnkU8GAA==
- Ironport-hdrordr: A9a23:2Qev1aijkG6JbpFT8WotB/UDB3BQXvMji2hC6mlwRA09TyXPrb HXoB19726RtN9xYgBEpTjjUJPrfZq4z/NICOYqUYtKMDOIhILKFvAB0WKB+V3d8nbFh5dgPM 5bGsAUNDSXNzZHZK3BkWqF+rgboeVuX8qT9JzjJ9sGd3AMV0nAhT0JbDqmLg==
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
- Thread-index: AQHYLVxwam4XOlcoM0qksn/nZK0dPqyqgvIAgAAQwwCAAAGngA==
- Thread-topic: [PATCH 2/2] x86/time: add CF-clobber annotations
On 01/03/2022 14:18, Jan Beulich wrote:
> On 01.03.2022 14:18, Andrew Cooper wrote:
>> On 01/03/2022 11:06, Jan Beulich wrote:
>>> With bed9ae54df44 ("x86/time: switch platform timer hooks to altcall")
>>> in place we can further arrange for ENDBR removal from the functions no
>>> longer subject to indirect calls. Note that plt_tsc is left untouched,
>>> for not holding any pointer eligible for ENDBR removal.
>> I'd be tempted to include it, for consistency sake alone.
>>
>> It is less likely to go wrong in the future if another hook is introduced.
> Can do, sure.
>
>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>> With the commit message, I'm not not certain if this is linked to the
>> previous patch.
>>
>> Overall it looks fine, but I'd like to get clarity on this point.
> Converting read_tsc() was discussed (with Roger) earlier on, so I'd
> view this as a separate change. As said in reply to your comments on
> the 1st patch, how exactly read_tsc() looks like is orthogonal to
> the changes here at least as long as it doesn't live in .text.
Ok. Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
|
