[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] x86/time: add CF-clobber annotations
- To: Andrew Cooper <Andrew.Cooper3@xxxxxxxxxx>
- From: Jan Beulich <jbeulich@xxxxxxxx>
- Date: Tue, 1 Mar 2022 15:45:34 +0100
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y6W/DUj8P73Qa56qkRd4IJ/l2Yw34qOaIaEzNLwsejY=; b=kB79BYkuM8bVOZwvFZtr8ew7jw4gyUngCq9iBgs+n3lYmVrt2vmtUYiF0gIETg7IUPz7HuYs2N4mURYiQcLrV9F5Gs7RY0b27JOGD4et/+G46FRJ0/Yo4TGZyFUSv3iCCV/vtprEYaNmXGoZkc5DfN7MQuyvORNYhEtkR5UBMUYDEmx6cvxYWqkFA/OVkwn9YTvBA9mA8Eqbg62x3QR/RDpeUbNxXOxUrBj7lyirJ1FRt7QayrIz6QW+UjbMZnU0WDpbQFeflua10LXvt0XwG4xp8zt56YhEZPBk4gZs79xh/YdLi92jZDgV/AOOQ+BNoJEblljaUmfZCl85smUbtw==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=enLtmbEmGZyacWRZr499XuTeJUA20AxWK+4EoUiEmUuaT5j60hHeXNTIQ5OP86SiKvJ4HzJe1FiiZEzHvwFwaYNwQx9/hkb+bBfuYkKs8vwGSh4LpdGaW874CnHZcxczLDI3oJQsdiyVVZ70I/V+/TM0shRMH+RjlGTUCspXtaCj+ynrUB87cqBOjBYVLx/ufaY2/szfOQJz4mIKQFNw22l3vlqPWsCHIp6zzXsAaukcXAxLFz8pC3sh7TsQvnI+PN5YfmTzj6D9WfxivN6J2CzKwcS+knTkO7zzCgaahMUHa9TSXRYVtk8Q+m5k/FHgLPh1N28WIpVd8riDBwU/FA==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com;
- Cc: Wei Liu <wl@xxxxxxx>, Roger Pau Monne <roger.pau@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxxx>
- Delivery-date: Tue, 01 Mar 2022 14:45:43 +0000
- List-id: Xen developer discussion <xen-devel.lists.xenproject.org>
On 01.03.2022 15:24, Andrew Cooper wrote:
> On 01/03/2022 14:18, Jan Beulich wrote:
>> On 01.03.2022 14:18, Andrew Cooper wrote:
>>> On 01/03/2022 11:06, Jan Beulich wrote:
>>>> With bed9ae54df44 ("x86/time: switch platform timer hooks to altcall")
>>>> in place we can further arrange for ENDBR removal from the functions no
>>>> longer subject to indirect calls. Note that plt_tsc is left untouched,
>>>> for not holding any pointer eligible for ENDBR removal.
>>> I'd be tempted to include it, for consistency sake alone.
>>>
>>> It is less likely to go wrong in the future if another hook is introduced.
>> Can do, sure.
>>
>>>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>>> With the commit message, I'm not not certain if this is linked to the
>>> previous patch.
>>>
>>> Overall it looks fine, but I'd like to get clarity on this point.
>> Converting read_tsc() was discussed (with Roger) earlier on, so I'd
>> view this as a separate change. As said in reply to your comments on
>> the 1st patch, how exactly read_tsc() looks like is orthogonal to
>> the changes here at least as long as it doesn't live in .text.
>
> Ok. Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
Thanks. I'll take it this includes annotating plt_tsc as well, just
as a precautionary measure (and as you did suggest; still visible in
context above).
Jan
|
